replace npm scripts commands with yarn #8833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
jroebu14
added
the
cross-team
jroebu14
requested review from
chris-hinds,
craigkj,
jamesdonoh,
j-pendlebury,
ryanmccombe and
sareh
as code owners
ryanmccombe
approved these changes
Feb 3, 2021
FK78
reviewed
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8761
Overall change:
Yarn only needs to be used for installing node modules e.g. npm install -> yarn install and npm install some-package -> yarn add some-package so this is a separate PR from migrating to Yarn for installing dependencies
We don't really need to do this but if we think we should commit fully to yarn and get into the habit of using it then we should probably merge this
Code changes:
npm runreferences withyarn runin scripts and docs.cross-teamlabel to this PR if it requires visibility across World Service teamsTesting:
CYPRESS_APP_ENV=local CYPRESS_SMOKE=false npm run test:e2e:interactive)