New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to yarn for installing dependencies #8762
Merged
Merged
Changes from 18 commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
8b436a0
migrate to yarn for install dependencies
6d12a3a
install emotion/react psammead peer dep
84a0d88
update bundle sizes
a8ffe06
update snapshots
3a34587
prevent running npm install
91f6d39
Merge branch 'latest' into migrate-to-yarn
43071df
add bolder npm install error message
8c836ce
test npm_execpath for testing
9ab623f
use yarn in GH actions
d81b953
make npm install error message slightly less bold
6c09be3
update bundle size config
809aac0
remove console.log
3bf9f74
use yarn install --frozen-lockfile
1f736c5
replace npm scripts commands with yarn
9cc523a
don't save puppeteer dep in yarn.lock
bd12fa2
remove unused script
6f8ea7c
Merge branch 'latest' into migrate-to-yarn
6a6addc
remove accidentally committed line of code
410a89c
enforce version of yarn
831f94c
don't save puppeteer dep in yarn.lock
0ed75df
remove unused script
8a5c63b
Merge branch 'latest' into migrate-to-yarn
56f0841
update contributing dox
93c3958
Merge branch 'migrate-to-yarn' of github.com:bbc/simorgh into migrate…
8a56381
loadable server and component packages must match
76ad6a9
later version of loadable introduces visual bugs
5ce7798
update int test snapshots
7e34ac0
Merge branch 'latest' into migrate-to-yarn
cd1667b
Merge branch 'migrate-to-yarn' into migrate-to-yarn-replace-npm-scripts
fdcb05d
Merge branch 'latest' into migrate-to-yarn
f86f61d
Merge branch 'migrate-to-yarn' of github.com:bbc/simorgh into migrate…
da93786
update contribution and link to from terminal
715c059
only nvm use required
f5ac634
add to and link to install yarn in root readme
31be900
add space in box
0b91d35
Merge branch 'latest' into migrate-to-yarn
5f51779
Merge branch 'latest' of github.com:bbc/simorgh into migrate-to-yarn
andrewscfc d522d16
update pre-push script
c4ba325
Merge branch 'migrate-to-yarn' of github.com:bbc/simorgh into migrate…
31f7a90
update yarn lock
andrewscfc 49ed388
Merge branch 'migrate-to-yarn' of github.com:bbc/simorgh into migrate…
andrewscfc 7b306e1
yarn import lock file
andrewscfc 75ed4ad
update snapshots after yarn import
andrewscfc a8d9cc2
reset loadable changes to match latest
andrewscfc a24a7c3
reset bundleSizeConfig
andrewscfc 9dae0a8
fix caching of node_modules in GH actions
9fdc15d
remove package-lock.json references
2a144ac
Merge branch 'latest' into migrate-to-yarn
dc63c18
update yarn.lock based on package-lock.json with yarn import command
f7df215
Merge pull request #8833 from bbc/migrate-to-yarn-replace-npm-scripts
2c077b7
remove `run` from yarn commands
57841a7
Merge branch 'latest' into migrate-to-yarn
def21db
Merge branch 'latest' into migrate-to-yarn
a619645
trigger build
4a8cac8
Merge branch 'latest' into migrate-to-yarn
3791687
remove @emotion/sheet webpack alias
2eb5ea7
match all emotion package versions
57c2d7e
upgrade emotion packages to latest
41f922e
update renovate docs to remove reference to forcing resolutions
andrewscfc 444c512
Merge branch 'latest' into migrate-to-yarn
12c9d6e
use latest versions of emotion packages in prod bundle
ad1be8a
add yarn ci script to remove invalid transitive dependencies before n…
014cd07
move transitive emotion deps to resolutions
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
version=1.22.10 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might be able to split this into installing puppeteer and running the tests. That way we can skip the puppeteer installation if it's in the cache.