perf(behavior_path_dynamic_avoidance_module): use const reference

[veqcc]

Description

This is a fix based on CppCheck warning

planning/behavior_path_dynamic_avoidance_module/src/scene.cpp:1806:46: performance: Function parameter 'outer_body_path' should be passed by const reference. [passedByValue]
      std::vector<geometry_msgs::msg::Point> outer_body_path) -> tier4_autoware_utils::Polygon2d {
                                             ^

Tests performed

No

Effects on system behavior

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[yuki-takagi-66]

I added const to the other args

[veqcc]

@yuki-takagi-66
Thank you for additional commit!!
Do you think those parameters should not be references?
I mean,

const strategy::distance_asymmetric<double> & path_expand_strategy,
const strategy::distance_asymmetric<double> & steer_expand_strategy,

[yuki-takagi-66]

@veqcc
Both acceptable, but I feel those parameters should not be references, because these are small enough
https://github.com/boostorg/geometry/blob/develop/include/boost/geometry/strategies/agnostic/buffer_distance_asymmetric.hpp

[veqcc]

@yuki-takagi-66
Thank you for your reply.
I agree to your point.

There is nothing to add from me anymore!!
Can I merge it?

[yuki-takagi-66]

@veqcc
Yes, please
Thank you so much