fix(autoware_overlay_rviz_plugin): fix subs and cleanup #6978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
github-actions
bot
added
type:documentation
xmfcx
added
the
tag:run-build-and-test-differential
vividf
pushed a commit
to vividf/autoware.universe
that referenced
this pull request
May 16, 2024
…dation#6978) Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Speed limit display didn't show the speed limit on startup or as the vehicle was driving.
Cause:
/planning/scenario_planning/current_max_velocitysubscriber wasn'ttransient_localas it should have been.Now it's fixed.
Reduced boilerplate by reusing subscription initializations.
autoware_overlay_msgswere added with this package but they weren't used. So I removed every trace of them.Cleaned up the CMakeLists file by removing redundant
find_package()calls. And overall formatting.Tests performed
Before
Speed limit is 0. It is only updated when I set it from the sidebar.
2024-05-11.02-31-44.mp4
After
Speed limit is 15, as it should be.
2024-05-11.02-28-11.mp4
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.