Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_autoware_utils): default QoS setting of polling subscriber #6976

Merged
merged 2 commits into from May 16, 2024

Conversation

soblin
Copy link
Contributor

@soblin soblin commented May 10, 2024

Description

  • add the argument for QoS to polling subscriber (default is QoS{1})
  • if the user did not specify depth == 1 for their custom QoS, raise exeception
  • rename getData() to takeData() that does the take() and getData() in one method
  • refactored obstacle_cruise for this change

Related links

Tests performed

works as before

Notes for reviewers

Interface changes

none

ROS Topic Changes

none

ROS Parameter Changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label May 10, 2024
@soblin soblin added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed component:common Common packages from the autoware-common repository. (auto-assigned) labels May 10, 2024
@soblin soblin force-pushed the feat/polling-subscriber-qos-arg branch from fcf22af to 775db2f Compare May 13, 2024 02:45
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label May 13, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the feat/polling-subscriber-qos-arg branch from 775db2f to f005883 Compare May 16, 2024 07:57
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 16, 2024
@soblin soblin merged commit 0de4a0a into autowarefoundation:main May 16, 2024
22 of 24 checks passed
@soblin soblin deleted the feat/polling-subscriber-qos-arg branch May 16, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants