fix(avoidance): improve avoidance safety check logic #6974
Merged
+23
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes following two commits:
1. don't exclude stopped object from safety check target unless it's a parked vehicle. d7b1589
Sometimes, the avoidance module couldn't react for vehicle on adjacent lane when the traffic signal changed RED to GREEN because it only checked moving objects. But there is a possibility that the stopped vehicle begins to move unless it's a parked vehicle.
simplescreenrecorder-2024-04-30_09.58.29.mp4
2. fix inconsistency between shift line generation and validation. 26521be
Sometimes, the avoidance module created unexpected avoidance path whose start point was closer than minimum prepare distance it must keep at least. And, using minimum prepare distance parameter in shift line generation logic caused this issue due to calculation error of post process (e.g. actual:0.9997 but threshold:1.0). In my thought, the parameter must be used only in validation logic. Hence, I created a funciton to validate shift line and use minimum prepare distance parameter only in it.
Tests performed
Effects on system behavior
Nothing.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.