Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): improve avoidance safety check logic #6974

Merged
merged 2 commits into from May 24, 2024

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented May 10, 2024

Description

This PR includes following two commits:

1. don't exclude stopped object from safety check target unless it's a parked vehicle. d7b1589

Sometimes, the avoidance module couldn't react for vehicle on adjacent lane when the traffic signal changed RED to GREEN because it only checked moving objects. But there is a possibility that the stopped vehicle begins to move unless it's a parked vehicle.

simplescreenrecorder-2024-04-30_09.58.29.mp4

2. fix inconsistency between shift line generation and validation. 26521be

Sometimes, the avoidance module created unexpected avoidance path whose start point was closer than minimum prepare distance it must keep at least. And, using minimum prepare distance parameter in shift line generation logic caused this issue due to calculation error of post process (e.g. actual:0.9997 but threshold:1.0). In my thought, the parameter must be used only in validation logic. Hence, I created a funciton to validate shift line and use minimum prepare distance parameter only in it.

Tests performed

Effects on system behavior

Nothing.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 10, 2024
@satoshi-ota satoshi-ota marked this pull request as ready for review May 22, 2024 23:52
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me.

@satoshi-ota satoshi-ota added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 24, 2024
@satoshi-ota satoshi-ota enabled auto-merge (squash) May 24, 2024 08:05
@satoshi-ota satoshi-ota merged commit 02775eb into autowarefoundation:main May 24, 2024
44 of 47 checks passed
@satoshi-ota satoshi-ota deleted the fix/avoidance-safety-check branch May 24, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants