Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_calibration_rviz_plugin): fix to set service name and exception failure #6973

Merged
merged 4 commits into from May 13, 2024

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented May 10, 2024

Description

I'll fix below

  • set service name
  • catch exceptions, for example, it occurs when topic is set to //accel_brake_calibrator/outout/update_suggest

Related links

Tests performed

I confirmed their behavior with accel_brake_map_calibrator, rqt and rviz...

output-2024-05-10_17.04.33.mp4

Notes for reviewers

Interface changes

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta requested a review from tkimura4 as a code owner May 10, 2024 08:06
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label May 10, 2024
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@tkimura4 tkimura4 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 10, 2024
@tkimura4 tkimura4 enabled auto-merge (squash) May 10, 2024 12:11
@h-ohta h-ohta changed the title fix(accel_brake_calibrator): fix to set service name and exception failure fix(tier4_calibration_rviz_plugin): fix to set service name and exception failure May 12, 2024
Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 15.39%. Comparing base (299b050) to head (6eadc2d).
Report is 6 commits behind head on main.

Files Patch % Lines
...in/src/accel_brake_map_calibrator_button_panel.cpp 0.00% 28 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #6973    +/-   ##
========================================
  Coverage   15.38%   15.39%            
========================================
  Files        1908     1908            
  Lines      133256   133146   -110     
  Branches    42309    42307     -2     
========================================
- Hits        20496    20492     -4     
+ Misses      90008    89903   -105     
+ Partials    22752    22751     -1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.39% <ø> (+0.01%) ⬆️ Carriedforward from 299b050

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tkimura4 tkimura4 merged commit bffbcce into autowarefoundation:main May 13, 2024
28 of 30 checks passed
@tkimura4 tkimura4 deleted the fix/accel_brake branch May 13, 2024 00:10
h-ohta added a commit to tier4/autoware.universe that referenced this pull request May 14, 2024
vividf pushed a commit to vividf/autoware.universe that referenced this pull request May 16, 2024
…ilure (autowarefoundation#6973)

* add service

* fix exception

* fix style

Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants