Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(default_ad_api): add heratbeat api #6969

Merged

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented May 10, 2024

Description

Add heartbeat API. See the documentation for details.

Related links

https://github.com/orgs/autowarefoundation/discussions/4561
autowarefoundation/autoware-documentation#536
https://autowarefoundation.github.io/autoware-documentation/main/design/autoware-interfaces/ad-api/features/heartbeat/

Tests performed

ros2 topic echo /api/system/heartbeat

Notes for reviewers

None

Interface changes

ROS Topic Changes

Topic Name Type Direction Update Description
/api/system/heartbeat autoware_adapi_v1_msgs/msgHeartbeat Publisher Heartbeat message.

ROS Parameter Changes

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@github-actions github-actions bot added component:system System design and integration. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels May 10, 2024
@isamu-takagi isamu-takagi marked this pull request as draft May 13, 2024 04:31
@isamu-takagi isamu-takagi self-assigned this May 15, 2024
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi marked this pull request as ready for review May 15, 2024 09:41
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r mitsudome-r added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 24, 2024
@mitsudome-r mitsudome-r enabled auto-merge (squash) May 24, 2024 12:45
@mitsudome-r mitsudome-r merged commit 7b51a43 into autowarefoundation:main May 24, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:system System design and integration. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants