Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rtc_interface)!: add new field to rtc cooperate status #6933

Merged
merged 3 commits into from May 13, 2024

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented May 8, 2024

Description

I added new field to tier4_rtc_msgs/CooperateStatus msgs.

Related links

tier4/tier4_autoware_msgs#119

Tests performed

Notes for reviewers

Please update tier4_autoware_msgs to latest one including tier4/tier4_autoware_msgs#119.

Interface changes

Update rtc cooperate status msg type in tier4/tier4_autoware_msgs#119.

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 8, 2024
@satoshi-ota satoshi-ota force-pushed the feat/rtc-add-new-field branch 2 times, most recently from 5a6b542 to 0bfebcc Compare May 9, 2024 09:37
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota removed the request for review from ktro2828 May 10, 2024 08:31
@github-actions github-actions bot removed the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label May 10, 2024
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 13, 2024
@satoshi-ota satoshi-ota changed the title feat(rtc_interface): add new field to rtc cooperate status feat(rtc_interface)!: add new field to rtc cooperate status May 13, 2024
@satoshi-ota satoshi-ota merged commit bd46dc3 into autowarefoundation:main May 13, 2024
63 of 66 checks passed
@satoshi-ota satoshi-ota deleted the feat/rtc-add-new-field branch May 13, 2024 04:54
vividf pushed a commit to vividf/autoware.universe that referenced this pull request May 16, 2024
…foundation#6933)

* feat(rtc_interface): add new field

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(bvp): support new rtc cooperate status

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(bpp): support new rtc cooperate status

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants