fix(lane_change): remove terminal in abort path #6930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4
force-pushed
the
revert-disable-terminal-in-abort
branch
from
2a408fb
to
5f8318c
Compare
zulfaqar-azmi-t4
added
the
tag:run-build-and-test-differential
zulfaqar-azmi-t4
requested review from
rej55,
kosuke55,
satoshi-ota,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
shmpwk
approved these changes
May 16, 2024
satoshi-ota
approved these changes
May 16, 2024
|
[imo] I prefer |
zulfaqar-azmi-t4
changed the title
zulfaqar-azmi-t4
merged commit ac8d50b
into
autowarefoundation:main
33 of 35 checks passed
zulfaqar-azmi-t4
added a commit
to tier4/autoware.universe
that referenced
this pull request
May 16, 2024
…n#6930) Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
zulfaqar-azmi-t4
added a commit
to tier4/autoware.universe
that referenced
this pull request
May 16, 2024
…n#6930) Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert terminal path calculation in abort path
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.