New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(obstacle_cruise_planner): support pointcloud-based obstacles #6907
Draft
mitukou1109
wants to merge
36
commits into
autowarefoundation:main
Choose a base branch
from
mitukou1109:obstacle_cruise_planner_pointcloud
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(obstacle_cruise_planner): support pointcloud-based obstacles #6907
mitukou1109
wants to merge
36
commits into
autowarefoundation:main
from
mitukou1109:obstacle_cruise_planner_pointcloud
+470
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
May 1, 2024
satoshi-ota
reviewed
May 1, 2024
@@ -87,6 +117,8 @@ struct Obstacle | |||
std::vector<PredictedPath> predicted_paths; | |||
double ego_to_obstacle_distance; | |||
double lat_dist_from_obstacle_to_traj; | |||
PointCloud pointcloud; | |||
bool pointcloud_repr; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain the purpose of this variable?
twist.linear.x = twist.linear.y = twist.angular.z = 0.0; | ||
|
||
Eigen::Vector4d centroid; | ||
pcl::compute3DCentroid(pointcloud, centroid); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you calculate centroid of pointcloud?
github-actions
bot
added
the
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
label
May 1, 2024
mitukou1109
force-pushed
the
obstacle_cruise_planner_pointcloud
branch
from
May 8, 2024 02:53
2802142
to
fb00bed
Compare
github-actions
bot
added
component:common
Common packages from the autoware-common repository. (auto-assigned)
component:simulation
Virtual environment setups and simulations. (auto-assigned)
labels
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:common
Common packages from the autoware-common repository. (auto-assigned)
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
component:simulation
Virtual environment setups and simulations. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related links
Tests performed
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.