Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_perception_launch): downsample perception input pointcloud #6886

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Apr 25, 2024

Description

This PR enables user to use downsampled pointcloud for whole perception process.

Recently, fast downsample filter was implemented by @yukkysaito in #6138.

With improvements in sensor performance, the number of point clouds from LiDAR is expected to continue to increase. Especially in large vehicles equipped with multiple LiDARs, it has been found that there is significant latency in subsequent processing (mainly ground segmentation), which is why there is a desire to limit the number of point clouds as much as possible.

Currently, there are no modules in perception that require dense point clouds, and in centerpoint, having too many input point clouds can lead to decreased recognition performance due to constraints on the number of input point clouds. Therefore, it is proposed to downsample the point clouds used in perception at the earliest stage.

Related links

Tests performed

See perception common scenario results

Tested with xx1-gen2 vehicle in TIER IV.

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Apr 25, 2024
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@YoshiRi YoshiRi self-assigned this Apr 26, 2024
@YoshiRi YoshiRi marked this pull request as ready for review April 26, 2024 11:04
@YoshiRi YoshiRi added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Apr 26, 2024
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@YoshiRi YoshiRi requested a review from soblin as a code owner April 26, 2024 11:13
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Apr 26, 2024
@github-actions github-actions bot removed the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label May 9, 2024
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi YoshiRi enabled auto-merge (squash) May 13, 2024 16:00
@YoshiRi YoshiRi merged commit b6bd750 into autowarefoundation:main May 13, 2024
22 checks passed
@YoshiRi YoshiRi deleted the feat/downsapmple_perception_input_pointclouds branch May 13, 2024 16:13
vividf pushed a commit to vividf/autoware.universe that referenced this pull request May 16, 2024
…autowarefoundation#6886)

* feat: downsample perception input pointcloud

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix: add group if to switch downsample node

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix: add test and exec depend

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* Update launch/tier4_perception_launch/launch/perception.launch.xml

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

* chore: refactor perception.launch.xml

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants