feat: update trafficlight roi styling #6985
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 12, 2024 02:26
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
KhalilSelyan
added
component:perception
5 tasks
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
|
@KhalilSelyan Can you share a screenshot of what the visualization will look like, it might be nice to have it in the README. |
xmfcx
reviewed
May 12, 2024
perception/traffic_light_visualization/src/traffic_light_roi_visualizer/shape_draw.cpp
Show resolved
Hide resolved
xmfcx
added
the
tag:run-build-and-test-differential
|
these are all the shapes would be drawn on top of the rectangle, and the probability would be on the side and out of 100 instead of 0.xxxxx |
added 4 commits
May 13, 2024 04:45
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
github-actions
bot
added
the
type:documentation
|
@xmfcx I made the update as requested, using the icons instead of cv draw
|
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
|
using the icons instead of cv:draw and more contained icon + probability |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces several enhancements to the traffic light ROI visualization in RViz to improve its accuracy and usability. Key changes include fixing the ROI colors to better match real-world traffic lights, replacing textual overlays with intuitive graphical shapes that represent the traffic light status, and adjusting the positioning and sizing of the probability of detection display. These updates aim to provide a cleaner, more informative visualization that aids users in better decision-making and data analysis.
Effects on System Behavior
These changes are visual and configurational; they do not affect the underlying system behavior of RViz or the traffic light detection functionalities. The visual enhancements are designed to improve user interaction without impacting system performance.
Pre-review Checklist for the PR Author
The PR author must check the checkboxes below when creating the PR.
In-review Checklist for the PR Reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review Checklist for the PR Author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.