New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply type annotations #1042
Merged
Merged
Apply type annotations #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are type|None to Union[type,None] since that convention started in Python3.10 and Androguard supports 3.9+, and note current circular import issue.
…on for Androguard..change these to Union[type,None]
…ferencing type hints using 'from __future__ import annotations'..however note that typing_extensions is still installed by some underlying package.
Thank you @ehrenb! Nicely done and well structured |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied type annotations to much of the code-base. May want to squash commits as there are a lot of redundant messages in the log..See more detailed notes below.
Union[type,None]
overtype|None
to keep changes compatible with Python3.9+.Optional[type]
could also been used here.from __future__ import annotations
which postpones evaluation of annotations and still allows for hints to be type names rather than strings.TYPE_CHECKING
checks to allow future static type checkign tools to run, such as mypy