Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply type annotations #1042

Merged
merged 24 commits into from Apr 28, 2024
Merged

Apply type annotations #1042

merged 24 commits into from Apr 28, 2024

Conversation

ehrenb
Copy link
Contributor

@ehrenb ehrenb commented Apr 27, 2024

Applied type annotations to much of the code-base. May want to squash commits as there are a lot of redundant messages in the log..See more detailed notes below.

… are type|None to Union[type,None] since that convention started in Python3.10 and Androguard supports 3.9+, and note current circular import issue.
…on for Androguard..change these to Union[type,None]
…ferencing type hints using 'from __future__ import annotations'..however note that typing_extensions is still installed by some underlying package.
@erev0s erev0s merged commit 319c398 into androguard:master Apr 28, 2024
1 check passed
@erev0s
Copy link
Collaborator

erev0s commented Apr 28, 2024

Thank you @ehrenb! Nicely done and well structured

@ehrenb ehrenb deleted the typing branch April 28, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants