Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply type annotations #1042

Merged
merged 24 commits into from
Apr 28, 2024
Merged

Apply type annotations #1042

merged 24 commits into from
Apr 28, 2024

Commits on Apr 27, 2024

  1. progress on typing

    @ehrenb
    ehrenb committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    98035fb View commit details
    Browse the repository at this point in the history

  2. finish typing analysis.py

    @ehrenb
    ehrenb committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    c754270 View commit details
    Browse the repository at this point in the history

  3. progress on typing dex/__init__.py

    @ehrenb
    ehrenb committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    30db069 View commit details
    Browse the repository at this point in the history

  4. finish pass at dex.__init__.py typing

    @ehrenb
    ehrenb committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    066b89a View commit details
    Browse the repository at this point in the history

  5. more types

    @ehrenb
    ehrenb committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    e30e140 View commit details
    Browse the repository at this point in the history

  6. more typing, and fix circular imports using 'if TYPE_CHECKING' checking

    @ehrenb
    ehrenb committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    43a7659 View commit details
    Browse the repository at this point in the history

  7. begin to change Generator->Iterator for typing, begin to returns that… 

    … are type|None to Union[type,None] since that convention started in Python3.10 and Androguard supports 3.9+, and note current circular import issue.
    @ehrenb
    ehrenb committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    6506fe6 View commit details
    Browse the repository at this point in the history

  8. type|None only works in Python3.10+, which is too high of an assumpti… 

    …on for Androguard..change these to Union[type,None]
    @ehrenb
    ehrenb committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    e837118 View commit details
    Browse the repository at this point in the history

  9. withoffset->with_offset

    @ehrenb
    ehrenb committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    2430407 View commit details
    Browse the repository at this point in the history

  10. fix circular import issue due to adding imports for typing

    @ehrenb
    ehrenb committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    59e45ee View commit details
    Browse the repository at this point in the history

  11. types for permission loading

    @ehrenb
    ehrenb committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    1de7f23 View commit details
    Browse the repository at this point in the history

  12. apply type hints to bytecode module

    @ehrenb
    ehrenb committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    ae104ae View commit details
    Browse the repository at this point in the history

  13. convert | to Union for further backwards compatibility, progress towa… 

    …rds typing axml
    @ehrenb
    ehrenb committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    dd521fb View commit details
    Browse the repository at this point in the history

  14. finish typing axml

    @ehrenb
    ehrenb committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    bf590bc View commit details
    Browse the repository at this point in the history

  15. order imports, standardize type|None -> Union[type,None]

    @ehrenb
    ehrenb committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    ccfd728 View commit details
    Browse the repository at this point in the history

  16. fix type for get_certificate_name_string param

    @ehrenb
    ehrenb committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    25672a9 View commit details
    Browse the repository at this point in the history

  17. explicitly import Name for typing

    @ehrenb
    ehrenb committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    f5572de View commit details
    Browse the repository at this point in the history

  18. standardize type|None -> Union[type,None]

    @ehrenb
    ehrenb committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    008c1d0 View commit details
    Browse the repository at this point in the history

  19. type annotate main

    @ehrenb
    ehrenb committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    409f616 View commit details
    Browse the repository at this point in the history

  20. fix some inaccurate hints

    @ehrenb
    ehrenb committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    0211c25 View commit details
    Browse the repository at this point in the history

  21. type hint fixes

    @ehrenb
    ehrenb committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    e531aec View commit details
    Browse the repository at this point in the history

  22. add imports for typing

    @ehrenb
    ehrenb committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    95966f8 View commit details
    Browse the repository at this point in the history

  23. remove unused import

    @ehrenb
    ehrenb committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    b8545d8 View commit details
    Browse the repository at this point in the history

  24. remove explicit dependence on typing_extensions, as we can do self-re… 

    …ferencing type hints using 'from __future__ import annotations'..however note that typing_extensions is still installed by some underlying package.
    @ehrenb
    ehrenb committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    99afe72 View commit details
    Browse the repository at this point in the history