Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate Python type hints #1025

Closed
wants to merge 11 commits into from

Conversation

zebrapurring
Copy link

This PR adds type hints to the Python functions, which help making the code more readable and maintainable. Development bugs such as #1023 can also be easily spotted in a properly typed codebase.

I didn't add typings for all the functions in the project, but I tried to cover the most used ones.

@ehrenb
Copy link
Contributor

ehrenb commented Mar 31, 2024

Hi, I am working on a more comprehensive pass at applying types to the entire project here: https://github.com/ehrenb/androguard/tree/typing. I think the related issue got closed here, which makes it less obvious that this was ongoing (#989 (comment)).

Also, the upgrade for PyQT5-QT5 will break the install for anyone not running MacOS I believe, see: #1018.

@erev0s
Copy link
Collaborator

erev0s commented Apr 28, 2024

Hi @zebrapurring, I want to emphasize that your contribution is valued, but was decided to go with another PR from @ehrenb (#1042) because it covers more ground and provides a more comprehensive solution. Thank you for your understanding and effort.

@erev0s erev0s closed this Apr 28, 2024
@zebrapurring
Copy link
Author

Hi @erev0s, no problem I just started this PR to add some basic coverage but didn't have time to follow up. Glad to see some typing support in mainline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants