Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWM Out Sim: provide same interface as in hardware #23146

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Pedro-Roque
Copy link
Member

Solved Problem

pwm_out_sim had a different interface to the values of PWM_MAIN_{MIN/MAX/FUNC/DIS/FAIL}{i} than hardware. This PR attempts at fixing that.

Solution

  • Added missing parameters to the module in question
  • Added the required interface in pwm_out_sim.cpp
  • Removed redundant "MAGIC" parameters in pwm_out_sim.hpp

Changelog Entry

For release notes:

Feature/Bugfix XYZ
New parameter: XYZ_Z
Documentation: Need to clarify page ... / done, read docs.px4.io/...

Alternatives

Keeping it as it was did not work since it would not allow for different PWM values than those hardcoded...

Test coverage

  • Unit/integration test: local format and unit tests checked out

Context

@Pedro-Roque Pedro-Roque requested a review from dagar May 16, 2024 18:55
@Pedro-Roque Pedro-Roque self-assigned this May 16, 2024
@Pedro-Roque Pedro-Roque added Sim: SITL software in the loop simulation Sim: HITL hardware in the loop simulation Sim: gazebo classic Gazebo classic simulator [Dev Call] ✅ Discussed labels May 16, 2024
@DronecodeBot
Copy link

This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:

https://discuss.px4.io/t/px4-sync-q-a-may-22-2024/38872/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Dev Call] ✅ Discussed Sim: gazebo classic Gazebo classic simulator Sim: HITL hardware in the loop simulation Sim: SITL software in the loop simulation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants