Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ekf optical flow only compensate to a lower value #23046

Closed
wants to merge 1 commit into from

Conversation

AlexKlimaj
Copy link
Member

@AlexKlimaj AlexKlimaj commented Apr 22, 2024

This PR is an attempt to remove fake velocity oscillations for the optical flow data. Where there is 0 or little pixel flow, the gyro noise oscillations dominate the optical flow velocity output.

Continuation of #22095

@dirksavage88

Current behavior in main.
image

Current behavior in main.
image

@AlexKlimaj AlexKlimaj requested review from dagar and bresch April 22, 2024 18:48
@dirksavage88
Copy link
Contributor

Will test this very soon @AlexKlimaj

Copy link
Member

@bresch bresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's assume you have a flow rate of 1rad/s and zero-mean gyro data with noise. If you simply subtract them, you'll get 1rad/s flow with noise. However, if you use your conditional subtraction, you'll get a signal with a mean < 1rad/s and some noise.

@dagar
Copy link
Member

dagar commented Apr 24, 2024

If we want to play with these ideas let's get a replayable log with GPS (or another reliable velocity/position source) at a few different altitudes.

@dagar dagar marked this pull request as draft April 24, 2024 19:49
@dirksavage88
Copy link
Contributor

gyro_comp_fixes

@AlexKlimaj
Copy link
Member Author

Not sure if my conditional subtraction is working.

https://review.px4.io/plot_app?log=960fafa5-0818-4d50-96be-42134be18775

@dirksavage88
Copy link
Contributor

I noticed the oscillations are far worse above 3m

@AlexKlimaj AlexKlimaj closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants