next/438/20240514/v1 #11072
Merged
next/438/20240514/v1 #11072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a rule has fast_pattern on base64_data, it is anyway not applied, so, consider any such rules invalid. Bug 5220
Task 6050
Ticket: 6973 Completes commit 2b4e102
And set it right for SIP and websocket, so that relevant tx app-layer metadata gets logged. Ticket: 6973
And also set close Ticket: 7025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11072 +/- ##
=======================================
Coverage 83.63% 83.63%
=======================================
Files 922 922
Lines 250321 250375 +54
=======================================
+ Hits 209349 209399 +50
- Misses 40972 40976 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
jasonish
approved these changes
May 14, 2024
|
Information: QA ran without warnings. Pipeline 20615 |
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging:
SV_BRANCH=OISF/suricata-verify#1831