-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fuzz: add target for DecodeBase64 #11032
Conversation
Task 6050
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11032 +/- ##
==========================================
+ Coverage 80.63% 83.65% +3.02%
==========================================
Files 922 922
Lines 250137 250321 +184
==========================================
+ Hits 201699 209411 +7712
+ Misses 48438 40910 -7528
Flags with carried forward coverage won't be shown. Click here to find out more. |
Information: QA ran without warnings. Pipeline 20537 |
@catenacyber I'll approve it if you think it's good. |
fuzz_decodebase64_SOURCES = tests/fuzz/fuzz_decodebase64.c | ||
fuzz_decodebase64_LDFLAGS = $(LDFLAGS_FUZZ) | ||
fuzz_decodebase64_LDADD = $(LDADD_FUZZ) | ||
if HAS_FUZZLDFLAGS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could pick the fix of 964a384 for this target already ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, did not see bugs in the first few minutes of running
Merged in #11072, thanks! |
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/6050
Previous PR: #11002
Changes since v10:
Note: Running 10+ mins on my system w/o any issues.