Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: add target for DecodeBase64 #11032

Closed
wants to merge 1 commit into from

Conversation

inashivb
Copy link
Member

@inashivb inashivb commented May 7, 2024

Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/6050

Previous PR: #11002

Changes since v10:

  • rebased

Note: Running 10+ mins on my system w/o any issues.

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.65%. Comparing base (abb7424) to head (59bdfc0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11032      +/-   ##
==========================================
+ Coverage   80.63%   83.65%   +3.02%     
==========================================
  Files         922      922              
  Lines      250137   250321     +184     
==========================================
+ Hits       201699   209411    +7712     
+ Misses      48438    40910    -7528     
Flag Coverage Δ
fuzzcorpus 64.30% <ø> (+0.03%) ⬆️
livemode 18.42% <ø> (-0.14%) ⬇️
suricata-verify 62.75% <ø> (?)
unittests 62.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 20537

@victorjulien
Copy link
Member

@catenacyber I'll approve it if you think it's good.

fuzz_decodebase64_SOURCES = tests/fuzz/fuzz_decodebase64.c
fuzz_decodebase64_LDFLAGS = $(LDFLAGS_FUZZ)
fuzz_decodebase64_LDADD = $(LDADD_FUZZ)
if HAS_FUZZLDFLAGS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could pick the fix of 964a384 for this target already ;-)

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, did not see bugs in the first few minutes of running

@victorjulien victorjulien added this to the 8.0 milestone May 14, 2024
@victorjulien
Copy link
Member

Merged in #11072, thanks!

@inashivb inashivb deleted the fuzz-base64/v11 branch May 15, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants