websocket: fix opcodes values for ping/pong #11065
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also set close Ticket: 7025
|
Can we add tests somehow so we would have caught this? |
Finaly found a pcap : OISF/suricata-verify#1829 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11065 +/- ##
==========================================
- Coverage 83.63% 83.62% -0.01%
==========================================
Files 922 922
Lines 250321 250321
==========================================
- Hits 209349 209327 -22
- Misses 40972 40994 +22
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
approved these changes
May 14, 2024
Merged
|
Merged in #11072, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7025
Describe changes:
SV_BRANCH=OISF/suricata-verify#1829