obs-studio-plugins.obs-backgroundremoval: 0.5.16 -> 1.1.13

[Zahrun]

Description of changes

occ-ai/obs-backgroundremoval@v0.5.16...1.1.13

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

Requires #228093 (includes tensorrt_provider_factory.h to build)

[spikespaz]

Does this still need to be a draft?

[Zahrun]

Still pending #228093

[Zahrun]

#260745 seems promising

[spikespaz]

I had trouble finding the most recent version of the plugin that builds with onnx 1.15.1 (current in unstable). I've been trying for well over an hour.

[Zahrun]

Maybe we could ask the plugin developers to provide a way to build it in CPU-only mode, which would not require tensorrt_provider_factory.h to build, if that is not already an option.

[Zahrun]

See occ-ai/obs-backgroundremoval#523

[Zahrun]

onnx seems fine. onnxruntime fails to build though. should be fixed by #258392 according to #281011 (comment)

[Zahrun]

Ok this builds now.
However it does not work yet.
It seems the plugin is not finding the model path.
info: [obs-backgroundremoval] Model file path: (null)

PS: On Ubuntu, that model is located at /usr/share/obs/obs-plugins/obs-backgroundremoval/models/mediapipe.onnx

PSS: also getting
warning: Failed to load 'en-US' text for module: 'obs-backgroundremoval.so'
later
error: [obs-backgroundremoval] Unable to get model filename models/mediapipe.onnx from plugin. error: [obs-backgroundremoval] Failed to create ONNXRuntime session. Error code: 1
and a lot of warning: [obs-backgroundremoval] Background mask is empty. This shouldn't happen. Using previous mask.

[Zahrun]

@spikespaz I opened an issue on the developers’ repo at occ-ai/obs-backgroundremoval#544.
This is probably more a Nix packaging issue but I’m not sure exactly what’s going on. If you have an idea, please suggest (or anyone else’s help is welcome of course)

[Zahrun]

Fixed the installation path by removing the extra /usr in the install cmake line.
Also updated to last release version.
Ready for review.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/3681

[SuperSandro2000]

Can't we use cmakeFlags and the normal phases?

[Zahrun]

cmakeFlags will apply to the normal buildPhase, right?
How to specify flags for installPhase?
Where is the documentation about this?

[spikespaz]

Is this PR still relevant or do we need a new one?

[Zahrun]

Is this PR still relevant or do we need a new one?

Sorry I forgot this was pending. In my head this was done and merged. Let me check the review comments.