Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obs-studio-plugins.obs-backgroundremoval: 0.5.16 -> 1.1.13 #230775

Merged
merged 3 commits into from Apr 28, 2024
Merged

obs-studio-plugins.obs-backgroundremoval: 0.5.16 -> 1.1.13 #230775

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59fd39e
obs-backgroundremoval: 0.5.16 -> 1.1.13
Zahrun May 8, 2023
ed83d08
Update pkgs/applications/video/obs-studio/plugins/obs-backgroundremov…
Zahrun Apr 27, 2024
c136052
relative path
Zahrun Apr 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
32 changes: 20 additions & 12 deletions pkgs/applications/video/obs-studio/plugins/obs-backgroundremoval/default.nix
View file
Open in desktop
Expand Up @@ -2,44 +2,52 @@
, stdenv
, fetchFromGitHub
, cmake
, ninja
, obs-studio
, onnxruntime
, opencv
, qt6
, curl
}:

stdenv.mkDerivation rec {
pname = "obs-backgroundremoval";
version = "0.5.16";
version = "1.1.13";

src = fetchFromGitHub {
owner = "royshil";
owner = "occ-ai";
repo = "obs-backgroundremoval";
rev = "v${version}";
hash = "sha256-E+pm/Ma6dZTYlX3DpB49ynTETsRS2TBqgHSCijl/Txc=";
rev = version;
hash = "sha256-QoC9/HkwOXMoFNvcOxQkGCLLAJmsja801LKCNT9O9T0=";
};

nativeBuildInputs = [ cmake ];
buildInputs = [ obs-studio onnxruntime opencv ];
nativeBuildInputs = [ cmake ninja ];
buildInputs = [ obs-studio onnxruntime opencv qt6.qtbase curl ];

dontWrapQtApps = true;

cmakeFlags = [
"--preset linux-x86_64"
"-DCMAKE_MODULE_PATH:PATH=${src}/cmake"
"-DUSE_SYSTEM_ONNXRUNTIME=ON"
"-DUSE_SYSTEM_OPENCV=ON"
"-DDISABLE_ONNXRUNTIME_GPU=ON"
];

postInstall = ''
mkdir $out/lib $out/share
mv $out/obs-plugins/64bit $out/lib/obs-plugins
rm -rf $out/obs-plugins
mv $out/data $out/share/obs
buildPhase = ''
cd ..
cmake --build build_x86_64 --parallel
'';

installPhase = ''
cmake --install build_x86_64 --prefix "$out"
'';
Comment on lines +37 to 44
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use cmakeFlags and the normal phases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmakeFlags will apply to the normal buildPhase, right?
How to specify flags for installPhase?
Where is the documentation about this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the project is using pretty new cmake stuff we don't have explicit support for.

cmakeFlags will apply to the normal buildPhase, right?

It applies to the configure phase

nixpkgs/pkgs/by-name/cm/cmake/setup-hook.sh

Lines 141 to 144 in c5b25a6

if [ -z "${dontUseCmakeConfigure-}" -a -z "${configurePhase-}" ]; then
setOutputFlags=
configurePhase=cmakeConfigurePhase
fi

How to specify flags for installPhase?

Apparently there is no hook for that.

Where is the documentation about this?

https://github.com/NixOS/nixpkgs/blob/master/doc/hooks/cmake.section.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok


meta = with lib; {
description = "OBS plugin to replace the background in portrait images and video";
homepage = "https://github.com/royshil/obs-backgroundremoval";
maintainers = with maintainers; [ zahrun ];
license = licenses.mit;
platforms = [ "x86_64-linux" "i686-linux" ];
platforms = [ "x86_64-linux" ];
};
}