Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File explorer not adjusting to macOS Mojave dark theme #59421

Closed
rosierjolie opened this issue Sep 26, 2018 · 4 comments · Fixed by #59742
Closed

File explorer not adjusting to macOS Mojave dark theme #59421

rosierjolie opened this issue Sep 26, 2018 · 4 comments · Fixed by #59742
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug mojave VS Code on OS X Mojave issues verified Verification succeeded
Milestone

Comments

@rosierjolie
Copy link

  • VSCode Version: Version 1.28.0-insider (1.28.0-insider)
  • OS Version: macOS Mojave Version 10.14

Steps to Reproduce:

  1. Select "Dark" appearance under system preferences > general.
  2. Open up Visual Studio Code.
  3. Click "File" and then "Open file..." (or command+o).

I have dark mode selected. However, when I select to open a file in VSCode, the finder window is still using the light theme instead of the dark theme as shown below.

screen shot 2018-09-25 at 8 57 26 pm

@vscodebot vscodebot bot added the insiders label Sep 26, 2018
@bpasero bpasero self-assigned this Sep 26, 2018
@bpasero bpasero added upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron mojave VS Code on OS X Mojave issues labels Sep 26, 2018
@sozercan
Copy link
Member

Set defaults write com.microsoft.VSCode NSRequiresAquaSystemAppearance 0 and use native tabs to get dark mode menus and titlebar.

image

@markovicdenis
Copy link

markovicdenis commented Sep 30, 2018

Set defaults write com.microsoft.VSCode NSRequiresAquaSystemAppearance 0 and use native tabs to get dark mode menus and titlebar.

@sozercan Perfect! Just a note for VSC Insiders users:

defaults write com.microsoft.VSCodeInsiders NSRequiresAquaSystemAppearance 0

@bpasero
Copy link
Member

bpasero commented Oct 1, 2018

Via #59742

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed electron Issues and items related to Electron insiders upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Oct 1, 2018
@bpasero bpasero added this to the October 2018 milestone Oct 1, 2018
@mjbvz mjbvz added the verified Verification succeeded label Oct 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug mojave VS Code on OS X Mojave issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants