Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dark window chrome when dark theme is used #10070

Closed
ganySA opened this issue Aug 3, 2016 · 11 comments
Closed

Support dark window chrome when dark theme is used #10070

ganySA opened this issue Aug 3, 2016 · 11 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone

Comments

@ganySA
Copy link

ganySA commented Aug 3, 2016

  • VSCode Version:
    1.3.1
  • OS Version:
    Windows 10
    Steps to Reproduce:

The toolbars and application menu are currently white/gray and many users have a dark theme for the code area and the contrast is quite :/

Any way to put in a option to make the toolbar and menu at the top of the screen to be black like in visual studio dark theme...

image

@coreh
Copy link

coreh commented Aug 5, 2016

Would also be really nice to have that for OS X:

@bpasero
Copy link
Member

bpasero commented Aug 6, 2016

I do not think Electron allows us to change the color of the area.

@bpasero bpasero added feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Aug 6, 2016
@bpasero bpasero added this to the Backlog milestone Aug 6, 2016
@bpasero bpasero changed the title Cosmetic: Toolbar / menu color Support dark window chrome when dark theme is used Aug 6, 2016
@coreh
Copy link

coreh commented Aug 8, 2016

It's possible from OS X 10.10 onwards, via the { titleBarStyle: 'hidden' } option:

https://github.com/electron/electron/blob/master/docs/api/frameless-window.md#alternatives-on-macos

Hyperterm (which is also electron-based) uses this option to great effect:

Controls are rendered by macOS, so the titlebar background just needs to be rendered using HTML content. The simplest way of doing this would be setting a margin-top style on the document body and a background color.

Changing it so that the tab bar blends more "Seamlessly" with the title bar is also possible, but would probably require more dramatic changes on VSCode's interface:

@bpasero bpasero removed their assignment Aug 17, 2016
@patrys
Copy link

patrys commented Oct 13, 2016

Here's a related PR that was merged into Atom: atom/atom#11790

@emeryao
Copy link

emeryao commented Jan 18, 2017

+1
Please think about it
REALLY need this feature

@ringoz
Copy link

ringoz commented Apr 14, 2017

+1
just do it!

@mikaturk
Copy link

mikaturk commented May 2, 2017

+1
Would really like to see this feature!

@bpasero bpasero added the menu label May 26, 2017
@armaandh
Copy link

armaandh commented Aug 5, 2017

+1 would really like to see this happen

@bpasero
Copy link
Member

bpasero commented Nov 15, 2017

#16363

@bpasero bpasero closed this as completed Nov 15, 2017
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 15, 2017
@1st
Copy link

1st commented Dec 3, 2017

As @patrys mentioned, the Atom has this black style title bar already. Can you please do the same change into the VS Code?

@jlewin
Copy link

jlewin commented Dec 14, 2017

GitHub Desktop also makes use of a dark titlebar:
image

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

10 participants