Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable mojave dark mode support #59742

Merged
merged 1 commit into from Oct 1, 2018

Conversation

MarshallOfSound
Copy link
Contributor

Electron is not built on the 10.14 SDK so we need to set a special Info.plist key to tell macOS we support dark mode.

Closes #59421
Closes #59283
Closes #54838 (maybe, the line looks a little different but I think it's how mojave dark mode windows look)

Blocked by: joaomoreno/gulp-atom-electron#51

@bpasero
Copy link
Member

bpasero commented Oct 1, 2018

@MarshallOfSound thanks. you can use this build (Electron 3.0.x included) to try it out: https://az764295.vo.msecnd.net/exploration/1e9d10654dfff127230af65393f0d3cd285ed2e4/VSCode-darwin-exploration.zip

@MarshallOfSound
Copy link
Contributor Author

@bpasero Works perfectly 👍

@bgarrant
Copy link

bgarrant commented Oct 2, 2018

When can we get this Mojave Dark Mode support for VS Code?

@bgarrant
Copy link

bgarrant commented Oct 2, 2018

@bpasero Is this expected out soon for VS Code? Dark Mode is so nice on the eyes

@MarshallOfSound MarshallOfSound deleted the feat/mojave-dark-mode branch October 2, 2018 11:14
@warpdesign
Copy link
Contributor

Is it fixed in insider builds? I still have the problem (even if macOS hasn't dark mode enabled, I see a gray line on top of VSCode).

@bpasero
Copy link
Member

bpasero commented Oct 8, 2018

Not yet out (this week), but you can use Electron 3.0.x builds where this fix is in:

@warpdesign
Copy link
Contributor

@bpasero unfortunately it doesn't fix the problem:

image

@bpasero
Copy link
Member

bpasero commented Oct 8, 2018

@warpdesign those builds are old, you should get an update and then its fine

@bpasero bpasero changed the title [WIP] feat: enable mojave dark mode support feat: enable mojave dark mode support Oct 11, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants