Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

title bar when using window.nativeTabs on MacOS doesn't respect Dark Mode setting #58240

Closed
nreilly opened this issue Sep 8, 2018 · 9 comments
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@nreilly
Copy link

nreilly commented Sep 8, 2018

  • VSCode Version: Version 1.27.1 (1.27.1)
  • OS Version: 10.14 Beta (18A384a)

Steps to Reproduce:

  1. Run Mojave (10.14)
  2. Enable Dark Mode (System Preferences > General > Appearance: Dark
  3. Enable window.nativeTabs in VSCode
  4. Expect dark title bar
  5. Get sad when it's light

Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Sep 8, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the new release label Sep 8, 2018
@nreilly
Copy link
Author

nreilly commented Sep 8, 2018

I don't think it is a duplicate as this is specific to supporting the dark mode feature introduced in 10.14 on MacOS

@bpasero
Copy link
Member

bpasero commented Sep 9, 2018

@nreilly can you share a screenshot?

@bpasero bpasero added info-needed Issue requires more information from poster and removed new release labels Sep 9, 2018
@vscodebot vscodebot bot closed this as completed Sep 16, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 16, 2018

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@fakebanana
Copy link

Here's a screenshot
vscode doesn t support dark mode

@aziz
Copy link

aziz commented Sep 19, 2018

This is not a duplicate and it's a real issue

@dlake89
Copy link

dlake89 commented Sep 26, 2018

Just confirmed this also. I added custom colors for the titlebar and they did not work until I changed nativeTabs to false. This was running the non-beta version of Mojave.

@mssngr
Copy link

mssngr commented Oct 4, 2018

I would also like to see this gain traction. The white tabs on the dark interface is really distracting.

@alesso-x
Copy link

alesso-x commented Oct 4, 2018

See #59283

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

8 participants