feat(tabs): Implement a couple of features and fix bugs of tabs #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix props data flow, fix children synchronization, add custom border
We can development component seperately, indipendent of doc and generate doc automatically
# Conflicts: # components/tabs/__tests__/__snapshots__/index.test.tsx.snap # pages/en-us/components/tabs.mdx
each playground is in seperate folder
# Conflicts: # components/utils/prop-types.ts
|
Task linked: CU-3tvnee Tab Component |
Fix forwardRef error so that Callers can recognize ref properfly; come up with a better way to extend Component
Just identify controlled component has some valid use case
remove useTabs; add test case
# Conflicts: # tsconfig.json
add file to lint in tsConfig
Codecov Report
@@ Coverage Diff @@
## dev #47 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 189 190 +1
Lines 2585 2613 +28
Branches 617 658 +41
=========================================
+ Hits 2585 2613 +28
Continue to review full report at Codecov.
|
GuichiZhao
changed the title
GuichiZhao
changed the title
# Conflicts: # pages/zh-cn/components/select.mdx
yqrashawn
reviewed
Aug 26, 2020
angelia-yuqi-personal
requested changes
Aug 26, 2020
.eslintignore
Outdated
| @@ -6,4 +6,6 @@ esm/* | |||
| public/* | |||
| scripts/* | |||
| tests/* | |||
| loaders/* | |||
| pages/code/* | |||
# Conflicts: # components/utils/prop-types.ts
angelia-yuqi-personal
approved these changes
Aug 28, 2020
yqrashawn
approved these changes
Aug 28, 2020
|
🎉 This PR is included in version 1.0.0-alpha.43 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Change information