forked from geist-org/geist-ui
-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(tabs): Implement a couple of features and fix bugs of tabs (#47)
* feat(tabs): fix/add feature to the Tabs component fix props data flow, fix children synchronization, add custom border * refactor(development): better dev/doc experience We can development component seperately, indipendent of doc and generate doc automatically * docs(tabs): add docs each playground is in seperate folder * test(tabs): remove invalid test * fix(tabs): unidentified ts build error * fix(tabs): fix ts error Fix forwardRef error so that Callers can recognize ref properfly; come up with a better way to extend Component * feat(tabs): add controlled componet style Just identify controlled component has some valid use case * test(tabs): improve coverage remove useTabs; add test case * style(tabs): ts lint add file to lint in tsConfig * test(tabs): update snapshot * feat(tabs): style is more customizable * feat(tabs): seperate label and bottom * feat(playground): load component as playground * feat(tabs and playground): add playground loader; Add useImperative for Tabs; Add examples Add examples using loader * fix: fix a syntax error due to merge possibly * test(tabs): add coverage Add test for individual component which are not possible covered by main component * feat(navigation): app Navigation Component * test(add expects to test): add expect * test(add expects to test): add expect * fix(tabs): use variables in style * fix(tabs): changes names to handle * fix(tabs): fix merge conflict * docs(tabs): rename files * docs(tabs): update docs to conform with API * fix(tabs): types defination * test(tabs): add coverage * test(tabs): update sanpshot * fix(tabs): update snapshot * fix(tabs): change nav from a function to a component * fix(tabs): change nav from a function to a component * fix(tabs): fix styles * fix(tabs): fix styles * fix(tabs): match design color * style(tabs): changes some inlie styles to css * style(tabs): fix colors * test(tabs): unpdate snapshot * style(tabs): change file name * style(tabs): change file name * fix(tabs): fix code review * style(tabs): fix tabs * feat(tabs): update the snapshot * refactor(tabs): style.ts * feat(tabs): remove code folder from ignore listy * chore(github): update codeowners * test(tabs): add a expect in a test case * test(tabs): use snapshot Co-authored-by: Chao Zhou <zctocm@gmail.com> Co-authored-by: yqrashawn <namy.19@gmail.com>
- Loading branch information
1 parent
7d45a44
commit 726bf7f
Showing
42 changed files
with
1,335 additions
and
716 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,4 +6,6 @@ esm/* | |
public/* | ||
scripts/* | ||
tests/* | ||
loaders/* | ||
# pages/code/* | ||
*.config.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.