forked from geist-org/geist-ui
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tabs): Implement a couple of features and fix bugs of tabs #47
Merged
Merged
Changes from 45 commits
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
1257eb2
feat(tabs): fix/add feature to the Tabs component
GuichiZhao a243b95
refactor(development): better dev/doc experience
GuichiZhao 517711d
Merge remote-tracking branch 'origin/dev' into Loading
GuichiZhao 3b60d1e
docs(tabs): add docs
GuichiZhao c852e77
test(tabs): remove invalid test
GuichiZhao a58f4de
Merge remote-tracking branch 'origin/dev' into Tabs
GuichiZhao 134d651
fix(tabs): unidentified ts build error
GuichiZhao 3a54512
fix(tabs): fix ts error
GuichiZhao fe3df09
feat(tabs): add controlled componet style
GuichiZhao 60d38ae
test(tabs): improve coverage
GuichiZhao 2f95105
Merge remote-tracking branch 'origin/dev' into Tabs
GuichiZhao f4ace93
style(tabs): ts lint
GuichiZhao b74b1f9
test(tabs): update snapshot
GuichiZhao e388dcf
feat(tabs): style is more customizable
GuichiZhao 5b0cdc9
feat(tabs): seperate label and bottom
GuichiZhao 1b69f08
feat(playground): load component as playground
GuichiZhao fbf3558
Merge branch 'dev' into Tabs
zctocm d4603d8
Merge branch 'dev' into Tabs
zctocm 3ba4711
feat(tabs and playground): add playground loader; Add useImperative f…
GuichiZhao 10faa03
Merge branch 'Tabs' of github.com:Conflux-Chain/react-ui into Tabs
GuichiZhao 0656c49
fix: fix a syntax error due to merge possibly
GuichiZhao a307b3c
Merge branch 'dev' into Tabs
GuichiZhao 2ab805a
test(tabs): add coverage
GuichiZhao 4c92ba0
Merge remote-tracking branch 'origin/dev' into Tabs
GuichiZhao 7c086d6
feat(navigation): app Navigation Component
GuichiZhao a38e90d
test(add expects to test): add expect
GuichiZhao e93fabb
test(add expects to test): add expect
GuichiZhao 620f1eb
fix(tabs): use variables in style
GuichiZhao 7aabc95
fix(tabs): changes names to handle
GuichiZhao 61fca68
Merge branch 'Nav' into Tabs
GuichiZhao ff56c41
fix(tabs): fix merge conflict
GuichiZhao c6aa71f
docs(tabs): rename files
GuichiZhao e91a2d3
docs(tabs): update docs to conform with API
GuichiZhao 418740e
fix(tabs): types defination
GuichiZhao 4b126d6
test(tabs): add coverage
GuichiZhao 2cfb3a7
test(tabs): update sanpshot
GuichiZhao 3f964c4
Merge remote-tracking branch 'origin/dev' into Tabs
GuichiZhao bbb1132
fix(tabs): update snapshot
GuichiZhao 5558f8b
fix(tabs): change nav from a function to a component
GuichiZhao 8e22237
fix(tabs): change nav from a function to a component
GuichiZhao f4e5854
Merge branches 'Tabs' and 'Tabs' of github.com:Conflux-Chain/react-ui…
GuichiZhao e918834
fix(tabs): fix styles
GuichiZhao 36c7d4a
fix(tabs): fix styles
GuichiZhao 9a849c0
Merge branch 'Tabs' of github.com:Conflux-Chain/react-ui into Tabs
GuichiZhao 6ca921e
fix(tabs): match design color
GuichiZhao 0408e6d
Merge branch 'dev' into Tabs
zctocm 8e797ca
style(tabs): changes some inlie styles to css
GuichiZhao 71a6b1a
Merge branches 'Tabs' and 'Tabs' of github.com:Conflux-Chain/react-ui…
GuichiZhao 84a8a70
style(tabs): fix colors
GuichiZhao 4ce96d1
test(tabs): unpdate snapshot
GuichiZhao e60ccae
style(tabs): change file name
GuichiZhao 7facfaa
style(tabs): change file name
GuichiZhao 1aa4b37
Merge branch 'Tabs' of github.com:Conflux-Chain/react-ui into Tabs
GuichiZhao a7f5f69
fix(tabs): fix code review
GuichiZhao e7c436a
style(tabs): fix tabs
GuichiZhao 0666b0b
Merge remote-tracking branch 'origin/dev' into Tabs
GuichiZhao bb8cca6
feat(tabs): update the snapshot
GuichiZhao b9f542a
Merge branch 'dev' into Tabs
yqrashawn c274f04
refactor(tabs): style.ts
yqrashawn 13cb45d
Merge remote-tracking branch 'origin/tabs-style-fix' into Tabs
GuichiZhao 346cc75
feat(tabs): remove code folder from ignore listy
GuichiZhao 1913a63
Merge remote-tracking branch 'origin/dev' into Tabs
GuichiZhao c47b8fe
chore(github): update codeowners
GuichiZhao 8179eb9
test(tabs): add a expect in a test case
GuichiZhao 1e21ecc
test(tabs): use snapshot
GuichiZhao 0222538
no message
GuichiZhao File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,4 +6,6 @@ esm/* | |
public/* | ||
scripts/* | ||
tests/* | ||
loaders/* | ||
pages/code/* | ||
*.config.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,20 @@ | |
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 | ||
"version": "0.2.0", | ||
"configurations": [ | ||
{ | ||
"name": "Launch via NPM", | ||
"request": "launch", | ||
"runtimeArgs": [ | ||
"run-script", | ||
"docs-collect" | ||
], | ||
"runtimeExecutable": "npm", | ||
"skipFiles": [ | ||
"<node_internals>/**" | ||
], | ||
"type": "pwa-node" | ||
}, | ||
Comment on lines
+8
to
+19
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. there's a new auto attach feature in vscode debugger, there's no need to specify a launch.json config if it's just for temporary use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
{ | ||
"type": "node", | ||
"name": "vscode-jest-tests", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why ignore the code examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the same reason as loaders
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we do need to lint example codes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so