Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop JQuery dependency #27

Open
tachyons opened this issue Oct 12, 2022 · 14 comments · Fixed by #28, #29, #34 or #35 · May be fixed by #40
Open

Drop JQuery dependency #27

tachyons opened this issue Oct 12, 2022 · 14 comments · Fixed by #28, #29, #34 or #35 · May be fixed by #40

Comments

@tachyons
Copy link
Member

Though we removed jquery ui, we still have jquery in our codebase. which need to be removed and use native DOM methods
@disha1202
Copy link
Contributor

Hi @tachyons,
I would like to work on this.

@tachyons
Copy link
Member Author

@disha1202 You can start working on this, but since jquery is used in several files, PR will be very huge. So I suggest you create PRs with changes per file. Also multiple people can work on this if you cab mention which file/files you want to work on

@disha1202
Copy link
Contributor

Sure @tachyons, I would like to start with Verilog2CV.js file.

@snehalshah8429
Copy link

@tachyons I would like to contribute on this

@snehalshah8429
Copy link

@disha1202 do you need any help in this project?

@disha1202 disha1202 mentioned this issue Nov 2, 2022
Merged
@disha1202
Copy link
Contributor

@tachyons, I've removed JQuery dependency in Verilog2CV.js file.
Please take a look.

@disha1202 disha1202 mentioned this issue Nov 2, 2022
Merged
@devartstar devartstar reopened this Nov 6, 2022
@devartstar devartstar reopened this Nov 8, 2022
@Prerna-0202 Prerna-0202 mentioned this issue Dec 15, 2022
Merged
This was referenced Dec 29, 2022
Merged
Merged
@tachyons tachyons reopened this Dec 30, 2022
This was referenced Dec 31, 2022
Open
Open
@GarvitSinghal47
Copy link
Contributor

@tachyons and @devartstar as there are multiple js files in which there is still jquery present in them I would like to work and help remove jquery from some of the files.

@GarvitSinghal47
Copy link
Contributor

Hey @tachyons as i discussed in the slack i am currently working on circuit.js file.

This was referenced Jan 26, 2023
Open
Open
This was referenced Feb 27, 2023
Open
Open
This was referenced Mar 10, 2023
Open
Closed
@Arnabdaz Arnabdaz linked a pull request Mar 22, 2023 that will close this issue
Open
2 tasks
@niladrix719
Copy link
Member

niladrix719 commented Oct 24, 2023 •
edited

i am working on actions.js

@niladrix719 niladrix719 linked a pull request Oct 24, 2023 that will close this issue
Open
@antriksh-9 antriksh-9 linked a pull request Dec 26, 2023 that will close this issue
Open
@DhairyaMajmudar DhairyaMajmudar mentioned this issue Dec 27, 2023
Open
@antriksh-9
Copy link

Hey @Arnabdaz @Prerna-0202 I have worked on PR #226.

@DhairyaMajmudar DhairyaMajmudar linked a pull request Dec 27, 2023 that will close this issue
Open
@antriksh-9
Copy link

I am working on testbench.js file.

@antriksh-9 antriksh-9 linked a pull request Dec 27, 2023 that will close this issue
Open
This was referenced Dec 28, 2023
Open
Open
Open
Open
Open
@antriksh-9
Copy link

antriksh-9 commented Dec 30, 2023 •
edited

I am working on testCreator.js file.

@antriksh-9 antriksh-9 linked a pull request Dec 30, 2023 that will close this issue
Open
@antriksh-9
Copy link

I am working on canvasApi.js file.

@antriksh-9 antriksh-9 linked a pull request Jan 4, 2024 that will close this issue
Open
@tachyons
Copy link
Member Author

tachyons commented Jan 9, 2024

Note: when you move transitions like fade from JQuery, use Vue transitions instead of trying to implement it vanilla JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: removed JQuery dependency in Verilog2CV.js file disha1202/cv-frontend-vue
refactor: removed JQuery dependency in tutorials.js file disha1202/cv-frontend-vue
refactor: removed JQuery dependency from verilog.js file disha1202/cv-frontend-vue
refactor: removed JQuery dependency from restrictedElementDiv.js file disha1202/cv-frontend-vue
refactor: removed JQuery dependency from plotArea.js file disha1202/cv-frontend-vue
refactor: removed JQuery dependency from listeners.js file disha1202/cv-frontend-vue
fix: jquery removal from circuit.js GarvitSinghal47/cv-frontend-vue
refactor: jquery removal from utils.js GarvitSinghal47/cv-frontend-vue
refactor: removed JQuery dependency from embed.js file GarvitSinghal47/cv-frontend-vue
refactor: removed JQuery from layoutMode.js file GarvitSinghal47/cv-frontend-vue
8 participants
@tachyons @disha1202 @devartstar @GarvitSinghal47 @niladrix719 @snehalshah8429 @antriksh-9 and others