Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removed JQuery dependency from testCreator.js file #240

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

antriksh-9
Copy link

Fixes #27

Removed JQuery dependency from testCreator.js file

Copy link

netlify bot commented Dec 30, 2023

Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit 6e0296a
🔍 Latest deploy log https://app.netlify.com/sites/circuitverse/deploys/6590796bbc66200008537ff9
😎 Deploy Preview https://deploy-preview-240--circuitverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antriksh-9
Copy link
Author

@Arnabdaz @Prerna-0202 please review.

@Arnabdaz
Copy link
Member

Arnabdaz commented Jan 4, 2024

the test creator page is not yet migrated to vue so this pr would be put on hold you can always use it as proof of work.

@Arnabdaz Arnabdaz added the hold label Jan 4, 2024
@antriksh-9
Copy link
Author

Okay thanks! @Arnabdaz

.find('td')
.eq(inputCount + outputCount - 1)
.after(sData)
testBenchTable

Check failure

Code scanning / ESLint

disallow the use of undeclared variables unless mentioned in `/*global */` comments Error

'testBenchTable' is not defined.
.querySelector('tr')[1]
.querySelector('th')
[inputCount + outputCount - 1].insertAdjacentHTML('afterend', sHead)
testBenchTable

Check failure

Code scanning / ESLint

disallow the use of undeclared variables unless mentioned in `/*global */` comments Error

'testBenchTable' is not defined.
.after(s)
})
})
for (let group_i = 0; group_i < tables.length; group_i++) {

Check failure

Code scanning / ESLint

disallow the use of undeclared variables unless mentioned in `/*global */` comments Error

'tables' is not defined.
})
})
for (let group_i = 0; group_i < tables.length; group_i++) {
let currentTable = tables[group_i]

Check failure

Code scanning / ESLint

disallow the use of undeclared variables unless mentioned in `/*global */` comments Error

'tables' is not defined.
.after(resultCellData)
})
})
for (let group_i = 0; group_i < tables.length; group_i++) {

Check failure

Code scanning / ESLint

disallow the use of undeclared variables unless mentioned in `/*global */` comments Error

'tables' is not defined.

outputCount--
$('#tb-outputs-head').attr('colspan', outputCount)
outputHead.setAttribute('colspan', outputCount)

Check failure

Code scanning / ESLint

disallow the use of undeclared variables unless mentioned in `/*global */` comments Error

'outputHead' is not defined.
.html()
bitwidths[inp] = Number(bw)
})
let secondRow = testBenchTable.querySelector('tr')[1]

Check failure

Code scanning / ESLint

disallow the use of undeclared variables unless mentioned in `/*global */` comments Error

'testBenchTable' is not defined.
thElements.forEach(function (th, index) {
let inp = th.textContent

let tdElement = testBenchTable

Check failure

Code scanning / ESLint

disallow the use of undeclared variables unless mentioned in `/*global */` comments Error

'testBenchTable' is not defined.
csvData += getGroupTitle(group_i)
csvData += '\n'
csvData += $(this).table2CSV()

csvData += tableToCSV(table)

Check failure

Code scanning / ESLint

disallow the use of undeclared variables unless mentioned in `/*global */` comments Error

'tableToCSV' is not defined.
}
})

table.addEventListener('dragend', function (event) {

Check failure

Code scanning / ESLint

disallow unused variables Error

'event' is defined but never used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop JQuery dependency
2 participants