Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor : Removing JQuery from minimap.js file #233

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

DhairyaMajmudar
Copy link
Contributor

@DhairyaMajmudar DhairyaMajmudar commented Dec 28, 2023

Fixes #27
Fixes #59

part of #230

Describe the changes you have made in this PR -

  • Removed the JQuery code from the minimap.js file

  • Removed the bug because which minimap was not showing.

Screenshots of the changes (If any) -

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Copy link

netlify bot commented Dec 28, 2023

Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit 36e3b32
🔍 Latest deploy log https://app.netlify.com/sites/circuitverse/deploys/65a7f7b5ed271600089e4f91
😎 Deploy Preview https://deploy-preview-233--circuitverse.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DhairyaMajmudar DhairyaMajmudar changed the title Removing jquery from minimap.js Refactor : Removing JQuery from minimap.js file Dec 28, 2023
@DhairyaMajmudar
Copy link
Contributor Author

@Arnabdaz @tachyons I have updated my PR with vue transitions. Also, the minimap was not showing which is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add: Mini map in the canvas. Drop JQuery dependency
1 participant