Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor : Removing Jquery from various files #230

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

DhairyaMajmudar
Copy link
Contributor

@DhairyaMajmudar DhairyaMajmudar commented Dec 27, 2023

Fixes #27

Describe the changes you have made in this PR -

Removal of JQuery code from files

  1. action.js
  2. minimap.js
  3. setup.js
  4. save.js
  5. Text.js
  6. Table2csv.js

Screenshots of the changes (If any) -

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

Copy link

netlify bot commented Dec 27, 2023

Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit b28804c
🔍 Latest deploy log https://app.netlify.com/sites/circuitverse/deploys/658d0fb251475c000863b68a
😎 Deploy Preview https://deploy-preview-230--circuitverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DhairyaMajmudar
Copy link
Contributor Author

@devartstar @Arnabdaz @Prerna-0202 I have also removed JQuery from the actions.js file pls .review this and suggest the changes if required : )

@DhairyaMajmudar
Copy link
Contributor Author

@tachyons @Arnabdaz I have removed Jquery code form several files pls. review the PR and suggest any changes if req.

Thank You : )

@tachyons
Copy link
Member

tachyons commented Dec 28, 2023

@DhairyaMajmudar Please make one PR per file. Also add a screenshot from netlify preview to ensure that feature is working properly after making the change.

@DhairyaMajmudar
Copy link
Contributor Author

@DhairyaMajmudar Please make one PR per file. Also add a screenshot from netlify preview to ensure that feature is working properly after making the change.

Sure I will follow up on the same and come up with individual PRs
Thank you for the suggestion.

@DhairyaMajmudar
Copy link
Contributor Author

DhairyaMajmudar commented Dec 28, 2023

@tachyons as suggested I have opened each separate PRs for each file.

PR. Nos:-
#233
#234
#235
#236
#237
#229

Pls. review them and suggest changes if any
Thank You : )

@tachyons
Copy link
Member

@DhairyaMajmudar great, could you please.qke sure that the screenshots are related to the files being changed. Eg when changing loading screen, the screenshot should include loading screen.

@DhairyaMajmudar
Copy link
Contributor Author

@tachyons I have updated my PR with the relevant screenshots

But some prs where having code changes which was either related to some logic, and that logic was used in several other files. As of which I am not able to provide SS proof for those prs.

Pls. review the code changes and merge my PRs if it looks good to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop JQuery dependency
2 participants