Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleep Timer: Stop at end of episode #2146

Open
mfietz opened this issue Oct 9, 2016 · 28 comments · May be fixed by #4754
Open

Sleep Timer: Stop at end of episode #2146

mfietz opened this issue Oct 9, 2016 · 28 comments · May be fixed by #4754
Labels
Needs: Decision Proposal and most arguments are clear, but needs a verdict. Type: Feature request

Comments

@mfietz
Copy link
Contributor

mfietz commented Oct 9, 2016

Request to stop when the episodes finishes came via email.

@mathstuf
Copy link

mathstuf commented May 9, 2017

It'd be nice to be able to say "at the end of N episodes" as well.

@kingston51
Copy link

Fully support this demand, I'm very much missing this option!

@woj-tek
Copy link

woj-tek commented Sep 30, 2019

That would be awesome to have. Currently in the queue the only option is to move the episode to the end of the list which will cause playback to stop after the episode finishes.

@yzerman19
Copy link

If you want to stop at the end of the current track, just set "Settings>Playback>Continuous Playback" to OFF. Of course, this will not help for the situation of snoozing after X episodes. In that case, i guess you could just put X episodes at the end of your queue, and leave continuous playback ON.

@woj-tek
Copy link

woj-tek commented Sep 30, 2019

I know that that I can do that. The issue boils down to what you want more: occasionally stop after current track or occasionally continue. In my case I usually want to binge-listen (so it's convenient for me to have "Continuous playback" ON (so I don't have to constantly reach for my phone to get to the next track) but sometimes I do want to listen to single track so, as mentioned before, I'm opting for placing it at the end of the queue. But it's kinda inconvenient if you have larger queue. I guess I can just use "move to the end of the queue" option in my case.

@yzerman19
Copy link

I understand. I am basically the opposite. I leave my "continuous playback" to OFF almost always, as most podcasts are very long, and hitting Play button every 2-3 hours is not a problem for me.

Occasionally I want to binge a bunch of short-video podcasts all at once via my Chromecast. In this case, I group all those videos together and I manually set "continuous playback" to ON so that I don't have to use my phone to hit Play every couple of minutes after each video. Once those are all played I go back and put the mode to OFF again.

@lenalebt
Copy link

So, for me it's like: I have a podcast that has 8-12 minutes episodes that I hear for sleeping. In almost all other cases I binge-hear while driving a car, so I cannot hit "play" again because I'm driving the car. Would really help to end after exactly this episode.

@jodergrosse
Copy link

I'd like to see this feature as well and gave implementing a quick shot.
I adapted the dialog and use the current episodes remaining time as sleep timer if the inserted switch is on. When activated the text field for manual input is deactivated.

Questions I'm wondering about:

  • should the sleep timer be synced with jumps which might happen after it was set?
  • what should a reset of the sleep timer do?

Any thoughts? Would you like me to create a pull request?

I guess setting a number of episodes after which to stop is possible, too. Would require more changes though.

dialog
dialog2

@ByteHamster
Copy link
Member

I'd like to see this feature as well and gave implementing a quick shot.

Awesome! I did not know that someone is working on the sleep timer. Yesterday, I modified the dialog, so you will probably get merge conflicts :/

should the sleep timer be synced with jumps which might happen after it was set?

Yes. We currently call resetSleepTimer() when starting playback. Maybe that function can also be called when jumping.

Have you tried adding "Stop after current episode" as an entry to the drop-down menu? I think that might look nice because it does not add additional interface clutter (and no elements need to be disabled). Your current implementation feels like "Stop after current episode" is a master switch for the dialog. I think that it should be equal to the existing time options.

Any thoughts? Would you like me to create a pull request?

Pull requests are always welcome :)

@Matth7878
Copy link

FYI pull request #3811 which changed sleep timer UI has been merged into develop branch.

When you speak about sleep timer synced with jumps you mean if you skip 30 secs sleep timer decrease (or increase) ? I think jumping forward or backward should not change anything. Yet if doing that starts another episode I think it is better to stop playing. Else it could lead to undesirable effect about when playing will end.

As for resetting sleep timer when set to expire after current episode resetting should not be possible since it makes no sense => in fact it would start a new timer to expire after current episode which make no difference so option should be greyed out when turning on expire after episode.

Off topic / issue : auto enable shouldn't be below "when timer is about to expire" as it is not an option about what to do when timer expires.

@ByteHamster
Copy link
Member

Off topic / issue : auto enable shouldn't be below "when timer is about to expire" as it is not an option about what to do when timer expires.

In #3811, I simply removed that heading :P

@Matth7878
Copy link

Didn't notice, nice ! It wasn't really annoying but it always seemed weird to me. ;-)

@jodergrosse
Copy link

@ByteHamster I was missing that feature and thought I should be able to work on it.
I did a quick search through the open issues and the google group to see if someone is working on it.
Probably a look through closed issues would have been a good idea, too. 😁

Thanks for pointing me out to your changes. I'll merge them and see whats new!

@Matth7878 I like the idea to keep the number of ui elements small. I would then expect to be able to set a number of episodes to stop after. Text input and drop down somehow belong together. Or the text input could be hid when the option is selected.
Reset could mean to play another episode till its end. But maybe that's to much anyway.

It would be nice to set the remaining play time after a jump again, using the existing count down mechanism. Of course the alternative could be to have the sleep timer stop the player without counting down time and just remembering to wait for the episodes end and then srop.

I think I'll keep it simple for now and just focus on setting the timer to the current episodes end. Will get back to it soonish.

@rubo77
Copy link

rubo77 commented Aug 30, 2020

Is the pr ready?

I really need a solution for this. (I stopped using antenna Pod due to this missing feature, but would love to come back to it.)

@jodergrosse
Copy link

Hi @rubo77
no Progress on my end so far. I would have to start over at this point, and haven't found the time so far. Feel free to jump in!

@asdoi
Copy link
Contributor

asdoi commented Oct 10, 2020

A very easy solution would be, that the stop at the end of the current track-checkbox only sets the sleep timer to the remaining time of the episode.
Then we do not have to deal with play/pause etc.
@ByteHamster if this is ok for you, I would prepare a pull request.

@ByteHamster
Copy link
Member

only sets the sleep timer to the remaining time of the episode.

Hmm, I do not think this will work reliably. Play/pause might change the time. Also, changed playback speeds or skipping would need to be taken into account. Doing it based on the time will probably end a few seconds too soon or too late in many cases.

@rubo77
Copy link

rubo77 commented Nov 24, 2020

Any updates on this?

I think this should have a real high priority

@kingston51
Copy link

kingston51 commented Nov 24, 2020 via email

@asdoi asdoi linked a pull request Dec 11, 2020 that will close this issue
@asdoi
Copy link
Contributor

asdoi commented Dec 11, 2020

Hi everybody,
apologies for the delay, I was very busy the last few weeks.
I created a new pull request (#4754) which works, if no checkboxes are ticked.
I would be very thankful if some of you could check the new option on their own phones, maybe there are some bugs in it that only happen in daily use.

@antennapod-bot
Copy link

This issue has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/set-the-off-timer-at-the-end-of-the-current-episode/689/2

@antennapod-bot
Copy link

This issue has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/sleep-timer-until-end-of-episode/1214/2

@antennapod-bot
Copy link

This issue has been mentioned on AntennaPod Forum. There might be relevant details there:

https://forum.antennapod.org/t/dont-auto-remove-podcasts-from-the-playlist-after-playing/996/5

@keunes keunes changed the title Sleep Timer: Stop at end of track Sleep Timer: Stop at end of episode Jan 3, 2022
@keunes
Copy link
Member

keunes commented Jan 3, 2022

Support for this feature in Google Play reviews:

1

Very good podcast app. Unfortunately, you cannot set "until the end of the episode" with the sleep timer, but only specify minutes. If this function ever exists, there are the 5 stars.

2

Good player. Removed one * for the fact that the sleep timer does not have an "at the end of the episode" setting

3

App sieht sehr gut aus, ich suche aber gerade die Möglichkeit einen Schlummer/Schlaftimer zu setzen, der stoppt wenn das Kapitel vorbei ist. Gerne einfügen. Danke für die open Source Arbeit

4

Please add End of Episode option for the sleep timer

5

Trying this out as a replacement for the currently-in-app-hospice Google Podcasts. Biggest feature I'm missing here is a sleep timer option for the end of the current episode

6

this app looks like a great replacement for google podcasts, but I'm really disappointed there's no option in the sleep timer to end whenever the current podcast does. I may have to keep looking, but I'll definitely be back if this is resolved!

7

Very granular in how I can sort everything, great podcast app. And you can import/export settings and subscriptions. Hoping it sticks around for a long time. All I'm missing is having a timer that can end at the end of an episode rather than just stop after a specific time.

8

Bin noch relativ neu bei AntennaPod, aber der Player gefällt mir. Einen Sleeptimer bis zum Ende der Folge gibt es allerdings nicht - da mir das sehr wichtig ist, gibt es einen Stern Abzug.

9

Just switched from Google Podcasts. Sleeptimerfunction is missing end of episode though. I just can set a certain time. Or do I miss something? Regards and thanks!

10

Absolutely the best of all in terms of clarity and control. There is only one thing missing for perfection - the ability to set sleep not only for a fixed time, but at the end of the episode you are listening to - as soon as it is, I will immediately add a fifth star.

11

Molt bona alternativa al Google Podcasts. No és perfecta perquè li falta el temporitzador fins al final d'episodi

@antennapod-bot
Copy link

antennapod-bot commented Apr 29, 2022

@keunes
Copy link
Member

keunes commented Oct 7, 2022

I'm still not sure about that. My gut feeling tells me that the vast majority of people who want this simply don't know that they can turn off "continuous playback". Adding it, we would have two different settings for the same use-case. (@ByteHamster in #6135)

I know I can turn off that setting, and I still would like 'stop at end of episode'. Continuous playback is a one-off setting that I have enabled by default, and I don't want to to the settings every odd night that I listen to a podcast in bed.

What's important, though, is that if the setting 'end at end of episode' the options to set the time and 'auto-enable' should be disabled and inactive. Because if

  • 'end of ep.' and 'auto-enable' are both active it has the same effect as continuous playback being disabled, and
  • continuous playback is enabled in the setting

this leads to u expected behaviour.

Implementation as described above avoids unexpected behaviour while still allowing one-off 'stop at end of episode' use.

@rubo77
Copy link

rubo77 commented Oct 9, 2022

This issue should be fixed by
Add episodes to sleep timer #4754

@AntennaPod AntennaPod locked and limited conversation to collaborators Oct 22, 2022
@keunes
Copy link
Member

keunes commented Oct 27, 2022

Given that #6148 removes the drop-down and #4751 relied on that drop-down to enable end-of-episode, we need to find a new UI approach. I would suggest to have two radio buttons:
🔘 Stop at end of episode
🔘 Stop after _______ minutes

Challenge is, though, to determine the alignment of the minutes box. Ideally, its alignment is flexible, such that it is moved horizontally (and vertically if needed) depending on the screen size, font size and length of the string (as the latter may differ quite a lot between languages).

As mentioned, when end-of-episode is active, the option Auto-enable should be disabled or even hidden (and the functionality disabled in the background, though ideally the selected state would be remembered).

@keunes keunes added the Needs: Decision Proposal and most arguments are clear, but needs a verdict. label Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Needs: Decision Proposal and most arguments are clear, but needs a verdict. Type: Feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.