New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sleep Timer: Stop at end of episode #2146
Comments
It'd be nice to be able to say "at the end of N episodes" as well. |
Fully support this demand, I'm very much missing this option! |
That would be awesome to have. Currently in the queue the only option is to move the episode to the end of the list which will cause playback to stop after the episode finishes. |
If you want to stop at the end of the current track, just set "Settings>Playback>Continuous Playback" to OFF. Of course, this will not help for the situation of snoozing after X episodes. In that case, i guess you could just put X episodes at the end of your queue, and leave continuous playback ON. |
I know that that I can do that. The issue boils down to what you want more: occasionally stop after current track or occasionally continue. In my case I usually want to binge-listen (so it's convenient for me to have "Continuous playback" ON (so I don't have to constantly reach for my phone to get to the next track) but sometimes I do want to listen to single track so, as mentioned before, I'm opting for placing it at the end of the queue. But it's kinda inconvenient if you have larger queue. I guess I can just use "move to the end of the queue" option in my case. |
I understand. I am basically the opposite. I leave my "continuous playback" to OFF almost always, as most podcasts are very long, and hitting Play button every 2-3 hours is not a problem for me. Occasionally I want to binge a bunch of short-video podcasts all at once via my Chromecast. In this case, I group all those videos together and I manually set "continuous playback" to ON so that I don't have to use my phone to hit Play every couple of minutes after each video. Once those are all played I go back and put the mode to OFF again. |
So, for me it's like: I have a podcast that has 8-12 minutes episodes that I hear for sleeping. In almost all other cases I binge-hear while driving a car, so I cannot hit "play" again because I'm driving the car. Would really help to end after exactly this episode. |
I'd like to see this feature as well and gave implementing a quick shot. Questions I'm wondering about:
Any thoughts? Would you like me to create a pull request? I guess setting a number of episodes after which to stop is possible, too. Would require more changes though. |
FYI pull request #3811 which changed sleep timer UI has been merged into develop branch. When you speak about sleep timer synced with jumps you mean if you skip 30 secs sleep timer decrease (or increase) ? I think jumping forward or backward should not change anything. Yet if doing that starts another episode I think it is better to stop playing. Else it could lead to undesirable effect about when playing will end. As for resetting sleep timer when set to expire after current episode resetting should not be possible since it makes no sense => in fact it would start a new timer to expire after current episode which make no difference so option should be greyed out when turning on expire after episode. Off topic / issue : auto enable shouldn't be below "when timer is about to expire" as it is not an option about what to do when timer expires. |
In #3811, I simply removed that heading :P |
Didn't notice, nice ! It wasn't really annoying but it always seemed weird to me. ;-) |
@ByteHamster I was missing that feature and thought I should be able to work on it. Thanks for pointing me out to your changes. I'll merge them and see whats new! @Matth7878 I like the idea to keep the number of ui elements small. I would then expect to be able to set a number of episodes to stop after. Text input and drop down somehow belong together. Or the text input could be hid when the option is selected. It would be nice to set the remaining play time after a jump again, using the existing count down mechanism. Of course the alternative could be to have the sleep timer stop the player without counting down time and just remembering to wait for the episodes end and then srop. I think I'll keep it simple for now and just focus on setting the timer to the current episodes end. Will get back to it soonish. |
Is the pr ready? I really need a solution for this. (I stopped using antenna Pod due to this missing feature, but would love to come back to it.) |
Hi @rubo77 |
A very easy solution would be, that the |
Hmm, I do not think this will work reliably. Play/pause might change the time. Also, changed playback speeds or skipping would need to be taken into account. Doing it based on the time will probably end a few seconds too soon or too late in many cases. |
Any updates on this? I think this should have a real high priority |
Fully agree !
…On Tue, Nov 24, 2020 at 8:06 AM Ruben Barkow-Kuder ***@***.***> wrote:
Any updates on this?
I think this should have a real high priority
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2146 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEZAT5VDW7AMP76X7LCK3WTSRNKNBANCNFSM4CSH5V5A>
.
|
Hi everybody, |
This issue has been mentioned on AntennaPod Forum. There might be relevant details there: https://forum.antennapod.org/t/set-the-off-timer-at-the-end-of-the-current-episode/689/2 |
This issue has been mentioned on AntennaPod Forum. There might be relevant details there: https://forum.antennapod.org/t/sleep-timer-until-end-of-episode/1214/2 |
This issue has been mentioned on AntennaPod Forum. There might be relevant details there: https://forum.antennapod.org/t/dont-auto-remove-podcasts-from-the-playlist-after-playing/996/5 |
Support for this feature in Google Play reviews:
|
This issue has been mentioned on AntennaPod Forum. There might be relevant details there: https://forum.antennapod.org/t/selective-automatic-sleep-by-connected-bluetooth-device/1968/2 https://forum.antennapod.org/t/continuous-playback-toggle/2908/3 https://forum.antennapod.org/t/restoring-the-queue-after-listening-overnight/3446/3 |
I know I can turn off that setting, and I still would like 'stop at end of episode'. Continuous playback is a one-off setting that I have enabled by default, and I don't want to to the settings every odd night that I listen to a podcast in bed. What's important, though, is that if the setting 'end at end of episode' the options to set the time and 'auto-enable' should be disabled and inactive. Because if
this leads to u expected behaviour. Implementation as described above avoids unexpected behaviour while still allowing one-off 'stop at end of episode' use. |
This issue should be fixed by |
Given that #6148 removes the drop-down and #4751 relied on that drop-down to enable end-of-episode, we need to find a new UI approach. I would suggest to have two radio buttons: Challenge is, though, to determine the alignment of the minutes box. Ideally, its alignment is flexible, such that it is moved horizontally (and vertically if needed) depending on the screen size, font size and length of the string (as the latter may differ quite a lot between languages). As mentioned, when end-of-episode is active, the option Auto-enable should be disabled or even hidden (and the functionality disabled in the background, though ideally the selected state would be remembered). |
Request to stop when the episodes finishes came via email.
The text was updated successfully, but these errors were encountered: