Add episodes to sleep timer #4754
Conversation
What do you mean with this one? Isn't it normal that nothing is playing after playback ended? ;) |
|
I see that this was not the best phrasing. I meant, that after the sleep timer ended the episode and stopped itself, the auto-enable option re-enables it. So that the playback stopped correctly, but the sleep timer is turned on again. |
|
Sorry, seeing your reply only now.
This also seems like expected behaviour, if auto-enable is activated. The only issue is that the effect is that the behaviour effectively is the same as when continuous playback is disabled. So I can imagine auto-enable is disabled & deactivated when 'at end of episode' is active. At least this potentially confused users. |
|
This pull request has been mentioned on AntennaPod Forum. There might be relevant details there: https://forum.antennapod.org/t/set-the-off-timer-at-the-end-of-the-current-episode/689/2 |
|
@asdoi Would you still be interested in this PR? Would be great to get this added in AntennaPod :) |
|
Sorry, it's actually my turn. I did not have a look at it yet. |
|
This pull request has been mentioned on AntennaPod Forum. There might be relevant details there: https://forum.antennapod.org/t/sleep-timer-until-end-of-episode/1214/2 |
|
This would be really great, to have this in the next release. What is the status? |
|
Same question from my side. Any plans to being this in soon? |
ByteHamster
added
the
Needs: Decision
|
Hi @ByteHamster, |
Continuation of #4535
Closes #4535
Closes #2146
This adds the basic functionality to the sleep timer to stop after the end of the
xth episode.I think this is ready for a short review, however there are two "bugs" with the checkboxes:
Vibrate shortly before end: The phone now vibrates when the last episode startsAuto-enable: After the playback ended the auto-enable option is triggered and reenables the sleep timer, but nothing is playing.