[ZKS-02] Introduce Committee IDs #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoglio
approved these changes
Feb 26, 2024
howardwu
approved these changes
Mar 2, 2024
mimoo
reviewed
Mar 10, 2024
| .map(|certificate| certificate.committee_id()) | ||
| .ok_or(anyhow!("No certificates found for subdag round {round}"))?; | ||
| ensure!( | ||
| certificates.iter().skip(1).all(|certificate| certificate.committee_id() == expected_committee_id), |
There was a problem hiding this comment.
OK so I think that makes sense to me, most of the DAG will likely be the same committee id, but any vertex that's on the same round (or previous round) as the last committed anchor will have a different committee id
There was a problem hiding this comment.
I think the intent is to reject those out of date cases during the proposal phase.
Do you see any concern that an out of date vertex could get 2f+1 signatures, be included in block production here, and cause a halting concern?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR introduces the concepts of committee IDs, which is a hash of the committee state:
BHP(starting_round || members || total_stake).This committee ID is used in batch headers to refer to a specific committee that was used to create the batch header. Other validators will then only sign batch headers/proposals if they see that the committee ID used refers to the committee that was expected. This will be an added safety guarantee when building the sudag/blocks, because validators will only certify batches if they are on the same committee state.
Audit Finding: [zksecurity 02] Dynamic Committee Feature is Not Safe