[ZKS-02] Add committee ID checks when processing proposals and certificates #3129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raychu86
changed the title
acoglio
approved these changes
Feb 26, 2024
howardwu
reviewed
Mar 3, 2024
Co-authored-by: Howard Wu <9260812+howardwu@users.noreply.github.com> Signed-off-by: Raymond Chu <14917648+raychu86@users.noreply.github.com>
howardwu
approved these changes
Mar 3, 2024
This was referenced Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds an additional committee ID check when processing batch proposals and batch certificates from peers. This check guarantees that the proposal/certificate from a validator must have the same committee id that your validator node expects for the given round, which means both validators have consistent committee state.
If this committee ID from a peer's batch proposal is not what was expected, that means the peer is either being malicious or has deviated state. The new logic will now ignore the proposal and disconnect from the peer in an attempt to not perpetuate a subdag based on deviated committee state.
The sister PR can be found here: AleoNet/snarkVM#2374
Audit Finding: [zksecurity 02] Dynamic Committee Feature is Not Safe