New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZKS-02] Introduce Committee IDs #2374
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9baf2c1
Introduce committee ID
raychu86 5af43e8
Add committee ID to batch header
raychu86 a253417
Store the committee ID in the Committee
raychu86 7da117e
Add committee ID checks to block verification
raychu86 ee10658
Regenerate genesis block
raychu86 182b263
Rewrite expectations
raychu86 a9df2bc
parallelize subdag committee id check
raychu86 fa3fbac
nit: reorder items
howardwu File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
// Copyright (C) 2019-2023 Aleo Systems Inc. | ||
// This file is part of the snarkVM library. | ||
|
||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at: | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
use super::*; | ||
|
||
impl<N: Network> Committee<N> { | ||
/// Returns the committee ID. | ||
pub fn to_id(&self) -> Result<Field<N>> { | ||
Self::compute_committee_id(self.starting_round, &self.members, self.total_stake) | ||
} | ||
} | ||
|
||
impl<N: Network> Committee<N> { | ||
/// Returns the commmitee ID. | ||
pub fn compute_committee_id( | ||
starting_round: u64, | ||
members: &IndexMap<Address<N>, (u64, bool)>, | ||
total_stake: u64, | ||
) -> Result<Field<N>> { | ||
let mut preimage = Vec::new(); | ||
// Insert the starting_round. | ||
starting_round.write_le(&mut preimage)?; | ||
// Write the number of members. | ||
u16::try_from(members.len())?.write_le(&mut preimage)?; | ||
// Write the members. | ||
for (address, (stake, is_open)) in members { | ||
// Write the address. | ||
address.write_le(&mut preimage)?; | ||
// Write the stake. | ||
stake.write_le(&mut preimage)?; | ||
// Write the is_open flag. | ||
is_open.write_le(&mut preimage)?; | ||
} | ||
// Insert the total stake. | ||
total_stake.write_le(&mut preimage)?; | ||
// Hash the preimage. | ||
N::hash_bhp1024(&preimage.to_bits_le()) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK so I think that makes sense to me, most of the DAG will likely be the same committee id, but any vertex that's on the same round (or previous round) as the last committed anchor will have a different committee id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the intent is to reject those out of date cases during the proposal phase.
Do you see any concern that an out of date vertex could get 2f+1 signatures, be included in block production here, and cause a halting concern?