Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input: Improve logging for keyboards and joysticks #25174

Merged
merged 6 commits into from May 16, 2024

Conversation

garbear
Copy link
Member

@garbear garbear commented May 10, 2024

Description

This PR contains improvements to input logging, needed to track down the remaining Android joystick bugs.

Motivation and context

Contains only the logging improvements broken out from #24604.

How has this been tested?

Tested as part of my RetroPlayer builds since January: https://github.com/garbear/xbmc/releases

What is the effect on users?

  • Improved input logging

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

@garbear
Copy link
Member Author

garbear commented May 15, 2024

@joseluismarti Do the android changes look OK to you?

Copy link
Contributor

@joseluismarti joseluismarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In NDK 26 some new codes appear (AKEYCODE_VIDEO_APP_n, AKEYCODE_FEATURED_APP_n and AKEYCODE_DEMO_APP_n) I don't know if they should be incorporated as well

I've checked that android_printf displays correctly the keycode and the translated string.

I haven't checked the button mapping part, but the concept is the same, I think it's good.

@garbear
Copy link
Member Author

garbear commented May 16, 2024

I've added the NDK 26 keycodes as a separate commit. Jenkins build and merge.

@jenkins4kodi jenkins4kodi merged commit 94b12dd into xbmc:master May 16, 2024
1 of 2 checks passed
@garbear garbear deleted the improve-logging branch May 17, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants