New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input: Improve logging for keyboards and joysticks #25174
Conversation
AKEYCODE_PROFILE_SWITCH is now the final key in keys.h as of NDK 21.4.7075529.
@joseluismarti Do the android changes look OK to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In NDK 26 some new codes appear (AKEYCODE_VIDEO_APP_n
, AKEYCODE_FEATURED_APP_n
and AKEYCODE_DEMO_APP_n
) I don't know if they should be incorporated as well
I've checked that android_printf
displays correctly the keycode and the translated string.
I haven't checked the button mapping part, but the concept is the same, I think it's good.
I've added the NDK 26 keycodes as a separate commit. Jenkins build and merge. |
Description
This PR contains improvements to input logging, needed to track down the remaining Android joystick bugs.
Motivation and context
Contains only the logging improvements broken out from #24604.
How has this been tested?
Tested as part of my RetroPlayer builds since January: https://github.com/garbear/xbmc/releases
What is the effect on users?
Types of change