Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Two fixes on the joystick codepath #25179

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

garbear
Copy link
Member

@garbear garbear commented May 10, 2024

Description

This PR contains two fixes for Android quirks on the joystick codepath:

  • Commit 2: Fixes PS4 controllers that identify as a mouse due to their touchpad
  • Commit 1: Fixes the middle buttons on my PS4 controller

Because only code on the joystick codepath is touched, this PR should have no effect on anything other than joysticks.

Motivation and context

Both fixes are hacks around Android quirks, but with both fixes my PS4 controller works in Kodi.

Because it only affects joysticks, it therefore separates out the remaining "safer" Android fixes from #24604.

I just bought a shiny new PS5 controller, so I'll test that with these fixes too.

How has this been tested?

Tested as part of my RetroPlayer builds since January: https://github.com/garbear/xbmc/releases

Due to the hacky nature of the fixes, more testing is needed. I plan to continue working on joysticks as the other PRs get merged:

What is the effect on users?

  • Fixes PS4 controllers on Android

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

@garbear garbear added this to the "P" 22.0 Alpha 1 milestone May 10, 2024
@garbear garbear mentioned this pull request May 10, 2024
8 tasks
@garbear garbear marked this pull request as draft May 10, 2024 08:23
@garbear
Copy link
Member Author

garbear commented May 10, 2024

OK, I've converted to draft. Upon review we clearly touch an input hot path and can potentially break mice. No bueno.

The remaining PS4 fix is also sus, but my PS4/PS5 testing will flush out the safety of this commit.

@garbear
Copy link
Member Author

garbear commented May 10, 2024

BTW, outside of the possibility of messing with mice on Android, there's no loss and only gain from this PR, so it'll continue to be included in my test builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant