Android: Fix unmapped joysticks (default joystick buttonmaps) #25176
+603
−85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Android ships buttonmaps for hundreds of controllers. When A is pressed, we get the keycode
AKEYCODE_BUTTON_A
because Android has a buttonmap for this controller.This PR harnesses Android buttonmaps by extending the default maps for keyboard and mice added in #24512, allowing a default map for joysticks to come from the peripheral bus.
The PR is separated into 4 commits:
Motivation and context
Fixes virtually every unmapped controller that Android can map.
Broken out from #24604
How has this been tested?
Tested as part of my RetroPlayer builds since January: https://github.com/garbear/xbmc/releases
Reports confirm that unmapped joysticks work in Kodi without needing to be mapped.
What is the effect on users?
Types of change