Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[commands] Add a method to get registered subsystems #6526

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spacey-sooty
Copy link
Contributor

Still needs C++, most likely to be done with
https://en.cppreference.com/w/cpp/ranges/keys_view depending on compatibility with llvm::DenseMap and C++ 20 support.

Resolves #6475

Still needs C++, most likely to be done with
https://en.cppreference.com/w/cpp/ranges/keys_view depending on
compatibility with `llvm::DenseMap` and C++ 20 support.

Resolves wpilibsuite#6475
@spacey-sooty
Copy link
Contributor Author

I'm getting a lot of errors with keys_view I don't think its going to work with llvm::DenseMap

@spacey-sooty spacey-sooty changed the title [cmd] Add a method to get registered subsystems [commands] Add a method to get registered subsystems May 11, 2024
@calcmogul
Copy link
Member

What's the error?

@spacey-sooty
Copy link
Contributor Author

output.txt

@KangarooKoala
Copy link
Contributor

std::ranges::key_view is an alias of std::ranges::elements_view, which requires that the container (in our case, wpi::DenseMap) satisfy std::ranges::view and be tuple-like (Or maybe the element type (in this case wpi::detail::DenseMapPair) be tuple-like?), which involves writing specializations of std::tuple_size and std::tuple_element. There's also something about std::get, but I'm not sure if that's going to be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to get list of registered subsystem
3 participants