PIDController.setIntegratorRange documentation fix
#6489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcmogul
requested changes
Mar 28, 2024
wpimath/src/main/java/edu/wpi/first/math/controller/PIDController.java
Outdated
Show resolved
Hide resolved
wpimath/src/main/java/edu/wpi/first/math/controller/PIDController.java
Outdated
Show resolved
Hide resolved
chauser
force-pushed
the
PIDControllerFixes
branch
from
b10c45b
to
521f4f0
Compare
chauser
changed the title
PIDController.setIntegratorRange documentation fix
calcmogul
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
PIDController.setIntegratorRangedocumentation issue in #6484.After further discussion, decided not to change the behavior for negative PID constants passed to the methods that modify them, enforcing non-negativity only at construction.