Navcurrent: Make current page's footer link bold #9308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "wb-navcurr" class changes colour schemes in the mega and secondary menus to visually-emphasize the current page. This adds a similar effect to footer links via bolding. It wouldn't of been practical to change text/background colours in that context since WET's footer links don't resemble buttons.
This was referenced Mar 14, 2022
duboisp
requested changes
Mar 16, 2022
There was a problem hiding this comment.
The change in this PR should be merged with your other related navcurrent PR #9307
Prior to apply this change, the style should only be applied when the link exactly match the current page, not an anchor. Like the footer link "About the Web Experience Toolkit" when navigating in the index.en.html page
Also, we will need to identify all the location where we are using that plugin. We need to evaluate the impact of this propose change.
TODO:
- Merge change with PR Navcurrent: Add aria-current="page" attribute #9307
- Identify all the instance that use this plugin. In GCWeb and wet-boew
- Ensure the style is only applied for exact match including the page anchor, not how the wb-navcurr plugin is currently working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "wb-navcurr" class changes colour schemes in the mega and secondary menus to visually-emphasize the current page.
This adds a similar effect to footer links via bolding. It wouldn't of been practical to change text/background colours in that context since WET's footer links don't resemble buttons.