Navcurrent: Add aria-current="page" attribute #9307
Conversation
The navcurrent plugin is a perfect fit for the aria-current attribute. The former adds a class ("wb-navcurr") to visually-denote links to the current page, whereas the latter represents it in semantics.
Scenarios this covers:
* Any links to the current page the plugin tries adding the "wb-navcurr" class to
Scenarios this won't cover:
* Top-level mega menu links that point to dropdown IDs (aria-current is inappropriate in those scenarios)
There was a problem hiding this comment.
The [aria-current=page] is only when the link is visually styled to represent the currently-displayed page. This is not the case with your proposed change.
I tested your propose fix with the /index-en.html page and looked at the link in the footer. There is link where the attribute is added and they are not styled appropriately. For example the link: About the Web Experience Toolkit
ref. https://www.w3.org/TR/2021/CRD-wai-aria-1.2-20211208/#aria-current
@duboisp IMO that's a CSS bug. #9308 will fix it in the WET theme (didn't add it to core since GCWeb currently doesn't use the navcurrent plugin at all). |
The navcurrent plugin is a perfect fit for the
aria-currentattribute. The former adds a class ("wb-navcurr") to visually-denote links to the current page, whereas the latter represents it in semantics.Scenarios this covers:
Scenarios this won't cover:
aria-currentis inappropriate in those scenarios)