Canada.ca local navigation menu current item/page not highlighted

[bedardk]

In previous releases the current item in the local navigation menu was highlighted with the wb-navcurr class. This seems to be missing in the latest release but it is working on Canada.ca WMS version.

Possibly related to #1512

ex.:

https://www.canada.ca/en/immigration-refugees-citizenship/services/application/check-status.html
https://wet-boew.github.io/themes-dist/GCWeb/localnav/task1/index-en.html

[duboisp]

The wb-navcurr CSS Class seem to be added by the server. The wb-navcurr plugin is designed in a way to be exclusively a helper plugin for other WET-BOEW plugin. Like wb-navcurr is a helper used by the WET menu plugin. It's special highlighted blue style come only from the menu plugin.

More analysis are required and its behaviour/purpose would need to be clarified.

[EricDunsworth]

Not sure how relevant left navs still are in GCWeb these days, but it looks this issue began when GCWeb replaced its old mega menu with its "MENU" dropdown.

While prepping wet-boew/wet-boew#9308, I noticed that the "wb-navcurr" class gets added to the current page's footer link in the WET theme, but doesn't in GCWeb. Both WET and GCWeb's footers use a hardcoded "wb-navcurr" class on a parent container, presumably to trigger the navcurrent plugin... but it doesn't actually do anything in practice.

What's really responsible for triggering the navcurrent plugin is WET's menu plugin:

• Mega menu: https://github.com/wet-boew/wet-boew/blob/5d3da072aab56aef387e64147380474d6dd7c6a6/src/plugins/menu/menu.js#L348-L379
• Section navigation: https://github.com/wet-boew/wet-boew/blob/5d3da072aab56aef387e64147380474d6dd7c6a6/src/plugins/menu/menu.js#L275-L276
• Footer: https://github.com/wet-boew/wet-boew/blob/5d3da072aab56aef387e64147380474d6dd7c6a6/src/plugins/menu/menu.js#L305-L306

So when the mega menu was dropped from GCWeb, navcurrent completely stopped working everywhere (i.e. "MENU" dropdown, section navigation and footer).

The wb-navcurr CSS Class seem to be added by the server.

This doesn't seem to have been the case. The "wb-navcurr" class wasn't hardcoded into the pages linked from the OP. It was dynamically added-in via the menu/navcurrent plugins.

Here are the Wayback Machine's snapshots of the OP's pages for reference:

• https://web.archive.org/web/20190403103440/https://www.canada.ca/en/immigration-refugees-citizenship/services/application/check-status.html
• https://web.archive.org/web/20181017093034/http://wet-boew.github.io/themes-dist/GCWeb/localnav/task1/index-en.html

@duboisp Should this issue be reclassified as a bug? It'd be great if navcurrent could be brought back to life in GCWeb.