Extend Navigation Timing API to include back/forward cache NotRestoredReasons #171

rubberyuzu · 2022-03-08T08:42:48Z

In TPAC 2021, we had a positive feedback on reporting back/forward cache NotRestoredReasons extending Navigation Timing API. e.g. Exposing why a page is not restored from back/forward cache in Navigation Timing API.
link to WG minutes

Here is the explainer: NotRestoredReason Explainer

Our proposal on how to propose NotRestoredReasons is below:

var perfEntries = performance.getEntriesByType("navigation");
for (var i=0; i < perfEntries.length; i++) {
	console.log("= Navigation entry[" + i + "]");
	var p = perfEntries[i];
	// p.notRestoredReason == [{URL:"a.com", Id: "x", blocked: True, reasons:["broadcast channel"], children:[]}]
}

Please let me know if you have any feedback on this. Thanks!

The text was updated successfully, but these errors were encountered:

yoavweiss · 2022-03-08T08:51:16Z

/cc @nicjansma @cliffcrocker @DanShappir @achristensen07 @sbougonSF @bdekoz @sefeng211 for opinions

crockercliff · 2022-03-08T23:16:41Z

This looks great! It seems like it would be a relatively simple addition to our RUM library. The only feedback so far from SpeedCurvers is related to the explainer. While it's fantastic to see the definitions and the 'how to fix' section is refreshing, there is concern about how maintainable this will be. We'd love to see a machine readable source for such things in the future.

rubberyuzu · 2022-03-09T08:30:51Z

Thanks for the comment!
Do you think linking to the web.dev article will help?
We have detailed examples of how to fix some of the blocking reasons, though not covering all:
article link

Please let me know what kind of format would be helpful. Thanks!

nicjansma · 2022-05-31T00:32:59Z

I think this will be a great thing for RUM providers to report on. We would integrate this into boomerang.js once available!

This CL adds back/forward cache not restored reasons in Performance NavigationTiming API. It's proposed here: w3c/navigation-timing#171 Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md This CL... - exposes not restored reasons to PerformanceNavigationTiming API - removes a flag from blink/common and adds one in RuntimeEnabled - changes blocklisted features' report string to be short - adds WPT Bug: 1349228 Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db

This CL adds back/forward cache not restored reasons in Performance NavigationTiming API. It's proposed here: w3c/navigation-timing#171 Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md This CL... (main) - exposes not restored reasons to PerformanceNavigationTiming API - adds WPT (sub/refactor) - removes a flag from blink/common and adds one in RuntimeEnabled - changes blocklisted features' report string to be short - changes when BackForwardCacheMetrics::UpdateNotRestoredReasonsForNavigation to be in SendCommitNavigation instead of DidCommitNavigation, so that at the time of sending the reasons it will be a complete list. Bug: 1349228 Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db

This CL adds back/forward cache not restored reasons in Performance NavigationTiming API. It's proposed here: w3c/navigation-timing#171 Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md This CL... (main) - exposes not restored reasons to PerformanceNavigationTiming API - adds WPT (sub/refactor) - removes a flag from blink/common and adds one in RuntimeEnabled - changes blocklisted features' report string to be short - changes BackForwardCacheMetrics::UpdateNotRestoredReasonsForNavigation to be in SendCommitNavigation instead of DidCommitNavigation, so that at the time of sending the reasons it will be a complete list. Bug: 1349228 Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db

This CL adds back/forward cache not restored reasons in Performance NavigationTiming API. It's proposed here: w3c/navigation-timing#171 Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md This CL... (main) - exposes not restored reasons to PerformanceNavigationTiming API - adds WPT (sub/refactor) - removes a flag from blink/common and adds one in RuntimeEnabled - changes blocklisted features' report string to be short - changes BackForwardCacheMetrics::UpdateNotRestoredReasonsForNavigation to also be called in SendCommitNavigation in addition to DidCommitNavigation, so that at the time of sending the reasons it will be a complete list. Bug: 1349228 Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db

This CL adds back/forward cache not restored reasons in Performance NavigationTiming API. It's proposed here: w3c/navigation-timing#171 Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md This CL does two things: - exposes not restored reasons to PerformanceNavigationTiming API - adds WPT Bug: 1349228 Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db

This CL adds back/forward cache not restored reasons in Performance NavigationTiming API. It's proposed here: w3c/navigation-timing#171 Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md This CL does two things: - exposes not restored reasons to PerformanceNavigationTiming API - adds WPT LOW_COVERAGE_REASON=Adding coverage for new field. Just missing the tests for the existing fields Bug: 1349228 Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db

This CL adds back/forward cache not restored reasons in Performance NavigationTiming API. It's proposed here: w3c/navigation-timing#171 Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md This CL does two things: - exposes not restored reasons to PerformanceNavigationTiming API - adds WPT The WPT have to run on all platforms because this API is intended to collect bfcache metrics from the wild, regardless of the platforms. LOW_COVERAGE_REASON=Adding coverage for new field. Just missing the tests for the existing fields Bug: 1349228 Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db

This CL adds back/forward cache not restored reasons in Performance NavigationTiming API. It's proposed here: w3c/navigation-timing#171 Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md This CL does two things: - exposes not restored reasons to PerformanceNavigationTiming API - adds WPT The WPT have to run on all platforms because this API is intended to collect bfcache metrics from the wild, regardless of the platforms. LOW_COVERAGE_REASON=Adding coverage for new field. Just missing the tests for the existing fields Bug: 1349228 Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835534 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Weizhong Xia <weizhong@google.com> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/main@{#1054800}

…onTiming" This reverts commit e1af9facf232a11871b0c668b90ec17c5a5d5e16. Reason for revert: Likely cause for multiple builder failures. For example, see https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ASan%20Tests%20(sandboxed)/93643/overview Original change's description: > [bfcache] Add notRestoredReasons field in PerformanceNavigationTiming > > This CL adds back/forward cache not restored reasons in Performance > NavigationTiming API. > It's proposed here: > w3c/navigation-timing#171 > Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md > > This CL does two things: > - exposes not restored reasons to PerformanceNavigationTiming API > - adds WPT > > The WPT have to run on all platforms because this API is intended to > collect bfcache metrics from the wild, regardless of the platforms. > > LOW_COVERAGE_REASON=Adding coverage for new field. Just missing the tests for the existing fields > > Bug: 1349228 > Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835534 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Weizhong Xia <weizhong@google.com> > Commit-Queue: Yuzu Saijo <yuzus@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1054800} Bug: 1349228 Change-Id: Iab0fed375560bb0b09bf4e8ea18b80c5d88b1375 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3935464 Owners-Override: Emily Shack <emshack@google.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Emily Shack <emshack@chromium.org> Cr-Commit-Position: refs/heads/main@{#1055015}

…onTiming" This is a reland of commit e1af9facf232a11871b0c668b90ec17c5a5d5e16 Original change's description: > [bfcache] Add notRestoredReasons field in PerformanceNavigationTiming > > This CL adds back/forward cache not restored reasons in Performance > NavigationTiming API. > It's proposed here: > w3c/navigation-timing#171 > Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md > > This CL does two things: > - exposes not restored reasons to PerformanceNavigationTiming API > - adds WPT > > The WPT have to run on all platforms because this API is intended to > collect bfcache metrics from the wild, regardless of the platforms. > > LOW_COVERAGE_REASON=Adding coverage for new field. Just missing the tests for the existing fields > > Bug: 1349228 > Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835534 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Weizhong Xia <weizhong@google.com> > Commit-Queue: Yuzu Saijo <yuzus@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1054800} Bug: 1349228 Change-Id: I010009593e15dcb9da20cc9ee4982294e935f57a

…onTiming" This is a reland of commit e1af9facf232a11871b0c668b90ec17c5a5d5e16 To address the test failure, in this reland I added IsOutermostMainFrame() condition in web_view_impl.cc. Original change's description: > [bfcache] Add notRestoredReasons field in PerformanceNavigationTiming > > This CL adds back/forward cache not restored reasons in Performance > NavigationTiming API. > It's proposed here: > w3c/navigation-timing#171 > Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md > > This CL does two things: > - exposes not restored reasons to PerformanceNavigationTiming API > - adds WPT > > The WPT have to run on all platforms because this API is intended to > collect bfcache metrics from the wild, regardless of the platforms. > > LOW_COVERAGE_REASON=Adding coverage for new field. Just missing the tests for the existing fields > > Bug: 1349228 > Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835534 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Weizhong Xia <weizhong@google.com> > Commit-Queue: Yuzu Saijo <yuzus@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1054800} Bug: 1349228 Change-Id: I010009593e15dcb9da20cc9ee4982294e935f57a

…onTiming" This is a reland of commit e1af9fa To address the test failure, in this reland I added IsOutermostMainFrame() condition in web_view_impl.cc. Original change's description: > [bfcache] Add notRestoredReasons field in PerformanceNavigationTiming > > This CL adds back/forward cache not restored reasons in Performance > NavigationTiming API. > It's proposed here: > w3c/navigation-timing#171 > Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md > > This CL does two things: > - exposes not restored reasons to PerformanceNavigationTiming API > - adds WPT > > The WPT have to run on all platforms because this API is intended to > collect bfcache metrics from the wild, regardless of the platforms. > > LOW_COVERAGE_REASON=Adding coverage for new field. Just missing the tests for the existing fields > > Bug: 1349228 > Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835534 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Weizhong Xia <weizhong@google.com> > Commit-Queue: Yuzu Saijo <yuzus@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1054800} Bug: 1349228 Change-Id: I010009593e15dcb9da20cc9ee4982294e935f57a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3934434 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#1055140}

…onTiming" This is a reland of commit e1af9facf232a11871b0c668b90ec17c5a5d5e16 To address the test failure, in this reland I added IsOutermostMainFrame() condition in web_view_impl.cc. Original change's description: > [bfcache] Add notRestoredReasons field in PerformanceNavigationTiming > > This CL adds back/forward cache not restored reasons in Performance > NavigationTiming API. > It's proposed here: > w3c/navigation-timing#171 > Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md > > This CL does two things: > - exposes not restored reasons to PerformanceNavigationTiming API > - adds WPT > > The WPT have to run on all platforms because this API is intended to > collect bfcache metrics from the wild, regardless of the platforms. > > LOW_COVERAGE_REASON=Adding coverage for new field. Just missing the tests for the existing fields > > Bug: 1349228 > Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835534 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Weizhong Xia <weizhong@google.com> > Commit-Queue: Yuzu Saijo <yuzus@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1054800} Bug: 1349228 Change-Id: I010009593e15dcb9da20cc9ee4982294e935f57a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3934434 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#1055140}

This CL adds back/forward cache not restored reasons in Performance NavigationTiming API. It's proposed here: w3c/navigation-timing#171 Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md This CL does two things: - exposes not restored reasons to PerformanceNavigationTiming API - adds WPT The WPT have to run on all platforms because this API is intended to collect bfcache metrics from the wild, regardless of the platforms. LOW_COVERAGE_REASON=Adding coverage for new field. Just missing the tests for the existing fields Bug: 1349228 Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835534 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Weizhong Xia <weizhong@google.com> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/main@{#1054800} NOKEYCHECK=True GitOrigin-RevId: e1af9facf232a11871b0c668b90ec17c5a5d5e16

…onTiming" This reverts commit e1af9facf232a11871b0c668b90ec17c5a5d5e16. Reason for revert: Likely cause for multiple builder failures. For example, see https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ASan%20Tests%20(sandboxed)/93643/overview Original change's description: > [bfcache] Add notRestoredReasons field in PerformanceNavigationTiming > > This CL adds back/forward cache not restored reasons in Performance > NavigationTiming API. > It's proposed here: > w3c/navigation-timing#171 > Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md > > This CL does two things: > - exposes not restored reasons to PerformanceNavigationTiming API > - adds WPT > > The WPT have to run on all platforms because this API is intended to > collect bfcache metrics from the wild, regardless of the platforms. > > LOW_COVERAGE_REASON=Adding coverage for new field. Just missing the tests for the existing fields > > Bug: 1349228 > Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835534 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Weizhong Xia <weizhong@google.com> > Commit-Queue: Yuzu Saijo <yuzus@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1054800} Bug: 1349228 Change-Id: Iab0fed375560bb0b09bf4e8ea18b80c5d88b1375 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3935464 Owners-Override: Emily Shack <emshack@google.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Emily Shack <emshack@chromium.org> Cr-Commit-Position: refs/heads/main@{#1055015} NOKEYCHECK=True GitOrigin-RevId: f48af8c89a823a0f20f1eb5c51871a0c8860d97f

…onTiming" This is a reland of commit e1af9facf232a11871b0c668b90ec17c5a5d5e16 To address the test failure, in this reland I added IsOutermostMainFrame() condition in web_view_impl.cc. Original change's description: > [bfcache] Add notRestoredReasons field in PerformanceNavigationTiming > > This CL adds back/forward cache not restored reasons in Performance > NavigationTiming API. > It's proposed here: > w3c/navigation-timing#171 > Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md > > This CL does two things: > - exposes not restored reasons to PerformanceNavigationTiming API > - adds WPT > > The WPT have to run on all platforms because this API is intended to > collect bfcache metrics from the wild, regardless of the platforms. > > LOW_COVERAGE_REASON=Adding coverage for new field. Just missing the tests for the existing fields > > Bug: 1349228 > Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835534 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Weizhong Xia <weizhong@google.com> > Commit-Queue: Yuzu Saijo <yuzus@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1054800} Bug: 1349228 Change-Id: I010009593e15dcb9da20cc9ee4982294e935f57a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3934434 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#1055140} NOKEYCHECK=True GitOrigin-RevId: 5a21d0235141012a993fd2b9aca8479dc6ab0a76

…n PerformanceNavigationTiming, a=testonly Automatic update from web-platform-tests [bfcache] Add notRestoredReasons field in PerformanceNavigationTiming This CL adds back/forward cache not restored reasons in Performance NavigationTiming API. It's proposed here: w3c/navigation-timing#171 Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md This CL does two things: - exposes not restored reasons to PerformanceNavigationTiming API - adds WPT The WPT have to run on all platforms because this API is intended to collect bfcache metrics from the wild, regardless of the platforms. LOW_COVERAGE_REASON=Adding coverage for new field. Just missing the tests for the existing fields Bug: 1349228 Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835534 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Weizhong Xia <weizhong@google.com> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/main@{#1054800} -- wpt-commits: 88c0d4ec3d12f5389297f08ced7785e2c402cf36 wpt-pr: 35764

… field in PerformanceNavigationTiming", a=testonly Automatic update from web-platform-tests Revert "[bfcache] Add notRestoredReasons field in PerformanceNavigationTiming" This reverts commit e1af9facf232a11871b0c668b90ec17c5a5d5e16. Reason for revert: Likely cause for multiple builder failures. For example, see https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ASan%20Tests%20(sandboxed)/93643/overview Original change's description: > [bfcache] Add notRestoredReasons field in PerformanceNavigationTiming > > This CL adds back/forward cache not restored reasons in Performance > NavigationTiming API. > It's proposed here: > w3c/navigation-timing#171 > Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md > > This CL does two things: > - exposes not restored reasons to PerformanceNavigationTiming API > - adds WPT > > The WPT have to run on all platforms because this API is intended to > collect bfcache metrics from the wild, regardless of the platforms. > > LOW_COVERAGE_REASON=Adding coverage for new field. Just missing the tests for the existing fields > > Bug: 1349228 > Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835534 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Weizhong Xia <weizhong@google.com> > Commit-Queue: Yuzu Saijo <yuzus@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1054800} Bug: 1349228 Change-Id: Iab0fed375560bb0b09bf4e8ea18b80c5d88b1375 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3935464 Owners-Override: Emily Shack <emshack@google.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Emily Shack <emshack@chromium.org> Cr-Commit-Position: refs/heads/main@{#1055015} -- wpt-commits: 9420f456c94ec948f7a93d99663d15b9622a4f01 wpt-pr: 36275

… field in PerformanceNavigationTiming", a=testonly Automatic update from web-platform-tests Reland "[bfcache] Add notRestoredReasons field in PerformanceNavigationTiming" This is a reland of commit e1af9facf232a11871b0c668b90ec17c5a5d5e16 To address the test failure, in this reland I added IsOutermostMainFrame() condition in web_view_impl.cc. Original change's description: > [bfcache] Add notRestoredReasons field in PerformanceNavigationTiming > > This CL adds back/forward cache not restored reasons in Performance > NavigationTiming API. > It's proposed here: > w3c/navigation-timing#171 > Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md > > This CL does two things: > - exposes not restored reasons to PerformanceNavigationTiming API > - adds WPT > > The WPT have to run on all platforms because this API is intended to > collect bfcache metrics from the wild, regardless of the platforms. > > LOW_COVERAGE_REASON=Adding coverage for new field. Just missing the tests for the existing fields > > Bug: 1349228 > Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835534 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Weizhong Xia <weizhong@google.com> > Commit-Queue: Yuzu Saijo <yuzus@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1054800} Bug: 1349228 Change-Id: I010009593e15dcb9da20cc9ee4982294e935f57a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3934434 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#1055140} -- wpt-commits: 8a56cdcecb36c38aed6a45654bd6f01b8f1095bf wpt-pr: 36277

…n PerformanceNavigationTiming, a=testonly Automatic update from web-platform-tests [bfcache] Add notRestoredReasons field in PerformanceNavigationTiming This CL adds back/forward cache not restored reasons in Performance NavigationTiming API. It's proposed here: w3c/navigation-timing#171 Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md This CL does two things: - exposes not restored reasons to PerformanceNavigationTiming API - adds WPT The WPT have to run on all platforms because this API is intended to collect bfcache metrics from the wild, regardless of the platforms. LOW_COVERAGE_REASON=Adding coverage for new field. Just missing the tests for the existing fields Bug: 1349228 Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835534 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Weizhong Xia <weizhong@google.com> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/main@{#1054800} -- wpt-commits: 88c0d4ec3d12f5389297f08ced7785e2c402cf36 wpt-pr: 35764

… field in PerformanceNavigationTiming", a=testonly Automatic update from web-platform-tests Revert "[bfcache] Add notRestoredReasons field in PerformanceNavigationTiming" This reverts commit e1af9facf232a11871b0c668b90ec17c5a5d5e16. Reason for revert: Likely cause for multiple builder failures. For example, see https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ASan%20Tests%20(sandboxed)/93643/overview Original change's description: > [bfcache] Add notRestoredReasons field in PerformanceNavigationTiming > > This CL adds back/forward cache not restored reasons in Performance > NavigationTiming API. > It's proposed here: > w3c/navigation-timing#171 > Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md > > This CL does two things: > - exposes not restored reasons to PerformanceNavigationTiming API > - adds WPT > > The WPT have to run on all platforms because this API is intended to > collect bfcache metrics from the wild, regardless of the platforms. > > LOW_COVERAGE_REASON=Adding coverage for new field. Just missing the tests for the existing fields > > Bug: 1349228 > Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835534 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Weizhong Xia <weizhong@google.com> > Commit-Queue: Yuzu Saijo <yuzus@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1054800} Bug: 1349228 Change-Id: Iab0fed375560bb0b09bf4e8ea18b80c5d88b1375 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3935464 Owners-Override: Emily Shack <emshack@google.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Emily Shack <emshack@chromium.org> Cr-Commit-Position: refs/heads/main@{#1055015} -- wpt-commits: 9420f456c94ec948f7a93d99663d15b9622a4f01 wpt-pr: 36275

… field in PerformanceNavigationTiming", a=testonly Automatic update from web-platform-tests Reland "[bfcache] Add notRestoredReasons field in PerformanceNavigationTiming" This is a reland of commit e1af9facf232a11871b0c668b90ec17c5a5d5e16 To address the test failure, in this reland I added IsOutermostMainFrame() condition in web_view_impl.cc. Original change's description: > [bfcache] Add notRestoredReasons field in PerformanceNavigationTiming > > This CL adds back/forward cache not restored reasons in Performance > NavigationTiming API. > It's proposed here: > w3c/navigation-timing#171 > Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md > > This CL does two things: > - exposes not restored reasons to PerformanceNavigationTiming API > - adds WPT > > The WPT have to run on all platforms because this API is intended to > collect bfcache metrics from the wild, regardless of the platforms. > > LOW_COVERAGE_REASON=Adding coverage for new field. Just missing the tests for the existing fields > > Bug: 1349228 > Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835534 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Weizhong Xia <weizhong@google.com> > Commit-Queue: Yuzu Saijo <yuzus@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1054800} Bug: 1349228 Change-Id: I010009593e15dcb9da20cc9ee4982294e935f57a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3934434 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#1055140} -- wpt-commits: 8a56cdcecb36c38aed6a45654bd6f01b8f1095bf wpt-pr: 36277

yoavweiss added this to New in Triage Mar 24, 2022

yoavweiss moved this from New to Discuss in Triage Mar 24, 2022

yoavweiss moved this from Discuss to Waiting on dependencies in Triage Apr 21, 2022

rubberyuzu mentioned this issue May 17, 2022

Early design review: Back/forward cache NotRestoredReasons API w3ctag/design-reviews#739

Closed

noamr added the enhancement label Jul 18, 2022

chromium-wpt-export-bot mentioned this issue Sep 2, 2022

[bfcache] Add notRestoredReasons field in PerformanceNavigationTiming web-platform-tests/wpt#35764

Merged

chromium-wpt-export-bot mentioned this issue Oct 4, 2022

Revert "[bfcache] Add notRestoredReasons field in PerformanceNavigationTiming" web-platform-tests/wpt#36275

Merged

chromium-wpt-export-bot mentioned this issue Oct 5, 2022

Reland "[bfcache] Add notRestoredReasons field in PerformanceNavigationTiming" web-platform-tests/wpt#36277

Merged

smaug---- mentioned this issue Dec 19, 2023

Add back/forward cache NotRestoredReasons whatwg/html#9360

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extend Navigation Timing API to include back/forward cache NotRestoredReasons #171

Extend Navigation Timing API to include back/forward cache NotRestoredReasons #171

rubberyuzu commented Mar 8, 2022 •

edited

yoavweiss commented Mar 8, 2022 •

edited

crockercliff commented Mar 8, 2022

rubberyuzu commented Mar 9, 2022

nicjansma commented May 31, 2022

Extend Navigation Timing API to include back/forward cache NotRestoredReasons #171

Extend Navigation Timing API to include back/forward cache NotRestoredReasons #171

Comments

rubberyuzu commented Mar 8, 2022 • edited

yoavweiss commented Mar 8, 2022 • edited

crockercliff commented Mar 8, 2022

rubberyuzu commented Mar 9, 2022

nicjansma commented May 31, 2022

rubberyuzu commented Mar 8, 2022 •

edited

yoavweiss commented Mar 8, 2022 •

edited