Skip to content

Commit

Permalink
Bug 1793701 [wpt PR 36275] - Revert "[bfcache] Add notRestoredReasons…
Browse files Browse the repository at this point in the history
… field in PerformanceNavigationTiming", a=testonly

Automatic update from web-platform-tests
Revert "[bfcache] Add notRestoredReasons field in PerformanceNavigationTiming"

This reverts commit e1af9facf232a11871b0c668b90ec17c5a5d5e16.

Reason for revert: Likely cause for multiple builder failures. For example, see https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ASan%20Tests%20(sandboxed)/93643/overview

Original change's description:
> [bfcache] Add notRestoredReasons field in PerformanceNavigationTiming
>
> This CL adds back/forward cache not restored reasons in Performance
> NavigationTiming API.
> It's proposed here:
> w3c/navigation-timing#171
> Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md
>
> This CL does two things:
> - exposes not restored reasons to PerformanceNavigationTiming API
> - adds WPT
>
> The WPT have to run on all platforms because this API is intended to
> collect bfcache metrics from the wild, regardless of the platforms.
>
> LOW_COVERAGE_REASON=Adding coverage for new field. Just missing the tests for the existing fields
>
> Bug: 1349228
> Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835534
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Weizhong Xia <weizhong@google.com>
> Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1054800}

Bug: 1349228
Change-Id: Iab0fed375560bb0b09bf4e8ea18b80c5d88b1375
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3935464
Owners-Override: Emily Shack <emshack@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Emily Shack <emshack@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1055015}

--

wpt-commits: 9420f456c94ec948f7a93d99663d15b9622a4f01
wpt-pr: 36275
  • Loading branch information
Emily Shack authored and moz-wptsync-bot committed Oct 21, 2022
1 parent 7ead8d2 commit 2f4a013
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 255 deletions.
Expand Up @@ -46,40 +46,3 @@ async function assertHeaderIsAsExpected(
return res.headers.get(headerName);
}, [headerName]), 'header is set');
}

async function assertNotRestoredReasonsEquals(
remoteContextHelper, blocked, url, src, id, name, reasons, children) {
let result = await remoteContextHelper.executeScript(() => {
return performance.getEntriesByType('navigation')[0].notRestoredReasons;
});
assertReasonsStructEquals(result, blocked, url, src, id, name, reasons, children);
}

function assertReasonsStructEquals(result, blocked, url, src, id, name, reasons, children) {
assert_equals(result.blocked, blocked);
assert_equals(result.url, url);
assert_equals(result.src, src);
assert_equals(result.id, id);
assert_equals(result.name, name);
// Reasons should match.
assert_equals(result.reasons.length, reasons.length);
reasons.sort();
result.reasons.sort();
for (let i=0; i<reasons.length; i++) {
assert_equals(result.reasons[i], reasons[i]);
}
// Children should match.
assert_equals(result.children.length, children.length);
children.sort();
result.children.sort();
for (let j=0; j<children.length; j++) {
assertReasonsStructEquals(result.children[0],
children[0].blocked,
children[0].url,
children[0].src,
children[0].id,
children[0].name,
children[0].reasons,
children[0].children);
}
}

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

0 comments on commit 2f4a013

Please sign in to comment.