Revert "[bfcache] Add notRestoredReasons field in PerformanceNavigationTiming" #36275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onTiming" This reverts commit e1af9facf232a11871b0c668b90ec17c5a5d5e16. Reason for revert: Likely cause for multiple builder failures. For example, see https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ASan%20Tests%20(sandboxed)/93643/overview Original change's description: > [bfcache] Add notRestoredReasons field in PerformanceNavigationTiming > > This CL adds back/forward cache not restored reasons in Performance > NavigationTiming API. > It's proposed here: > w3c/navigation-timing#171 > Explainer: https://github.com/rubberyuzu/bfcache-not-retored-reason/blob/main/NotRestoredReason.md > > This CL does two things: > - exposes not restored reasons to PerformanceNavigationTiming API > - adds WPT > > The WPT have to run on all platforms because this API is intended to > collect bfcache metrics from the wild, regardless of the platforms. > > LOW_COVERAGE_REASON=Adding coverage for new field. Just missing the tests for the existing fields > > Bug: 1349228 > Change-Id: I8dd96a60188bdff94a21c4e4e34cacf181a823db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3835534 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Weizhong Xia <weizhong@google.com> > Commit-Queue: Yuzu Saijo <yuzus@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1054800} Bug: 1349228 Change-Id: Iab0fed375560bb0b09bf4e8ea18b80c5d88b1375 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3935464 Owners-Override: Emily Shack <emshack@google.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Emily Shack <emshack@chromium.org> Cr-Commit-Position: refs/heads/main@{#1055015}
wpt-pr-bot
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e1af9facf232a11871b0c668b90ec17c5a5d5e16.
Reason for revert: Likely cause for multiple builder failures. For example, see https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ASan%20Tests%20(sandboxed)/93643/overview
Original change's description:
Bug: 1349228
Change-Id: Iab0fed375560bb0b09bf4e8ea18b80c5d88b1375
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3935464
Owners-Override: Emily Shack <emshack@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Emily Shack <emshack@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1055015}